Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove formatting lint rules #1427

Closed
zepumph opened this issue Mar 22, 2024 · 1 comment
Closed

remove formatting lint rules #1427

zepumph opened this issue Mar 22, 2024 · 1 comment
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Mar 22, 2024

We roped those into the main rules a long time ago, so let's get rid of them. Found this issue from #1415.

@zepumph zepumph self-assigned this Mar 22, 2024
@zepumph
Copy link
Member Author

zepumph commented Mar 22, 2024

These were the only rules we might want to keep:


    // enforce newline at the end of file, with no multiple empty lines
    'eol-last': [ 'error', 'never' ],

    // enforces empty lines around comments
    // PhET devs do not want this to be so strict in general
    'lines-around-comment': [ 'error', { beforeLineComment: true } ]

I would love to have the line before a comment, but other devs don't agree with this, and in fact, there are spots where I also like tucking a comment under a code line (like under an else{} clause). So I think we should not keep this around.

For eol-last, it seems like a nice and easy thing to keep around. I think it would be easy to turn on with a --fix. I'll make a new issue.

@zepumph zepumph closed this as completed Mar 22, 2024
zepumph added a commit to phetsims/rosetta that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/phet-info that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Mar 22, 2024
zepumph added a commit that referenced this issue Mar 22, 2024
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/circuit-construction-kit-ac-virtual-lab that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/circuit-construction-kit-common that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/center-and-variability that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/chains that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/number-line-common that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/buoyancy-basics that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/capacitor-lab-basics that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/charges-and-fields that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/geometric-optics that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/nitroglycerin that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/balancing-chemical-equations that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/number-line-operations that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/area-model-multiplication that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/friction that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/neuron that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/blackbody-spectrum that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/function-builder-basics that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/build-a-molecule that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/my-solar-system that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/diffusion that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/twixt that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/tambo that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/faradays-law that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/plinko-probability that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/simula-rasa that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/optics-lab that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/dot that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/tandem that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/eating-exercise-and-energy that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/magnet-and-compass that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/states-of-matter that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/hookes-law that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/tangible that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/waves-intro that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/phetmarks that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/wilder that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/wave-interference that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/proportion-playground that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/wave-on-a-string that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/trig-tour that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/phetcommon that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/fourier-making-waves that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Mar 22, 2024
zepumph added a commit to phetsims/alpenglow that referenced this issue Mar 22, 2024
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 17, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant