-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In dynamic locale dialog, some parens in RTL lang are in wrong direction #1379
Comments
In slack, @kathy-phet said:
@Nancy-Salpepi replied:
|
There is evidence this is a browser-specific bug. I tested https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.3.0-dev.20/phet-io/circuit-construction-kit-dc_all_phet-io.html?postMessageOnError&phetioStandalone in Chrome and Safari, and saw that Chrome is correct and Safari is incorrect. Here's the screenshot (Chrome on left, Safari on right): May also be related to #1355 |
Would it help to call wrapRTL like phetsims/build-a-molecule@8b6bc0c ? |
Actually it is incorrect in published BBL as well with safari. The issue I had opened was for the formulas. |
@samreid @zepumph @arouinfar and I discussed this, and note that this is not a sim-specific issue. We would like to reach out to @jonathanolson and @jbphet to provide insight into how this could be solved. |
Looking into it. I don't see directional marks in the string for some reason. |
It still works fine on Windows, Chrome. |
@jonathanolson and I are going to experiment a bit with isolates (see #1355) and see if it makes any different. |
Patched above. Browsers were making different guesses for directionality when we didn't have embedding marks in. |
@kathy-phet should this be maintenance-patched? I'll patch joist/phetcommon if so. |
FYI @samreid: this is fixed in Circuit Construction Kit: DC 1.3.0-rc.1 with mac + safari. |
MR'ed, closing! |
Test Device
MacBook Air
Operating System
macOS 12.4
Browser
Safari 15.5
Problem Description
Discovered during phetsims/qa#900. In the dynamic locale dialog, the parentheses in one of the Arabic language locales — I think it's
ar_MA
or Arabic (Morocco) — are in the wrong direction. I believe the parenthesis circled in red below should be an open parenthesis, not a close parenthesis.I am not sure if this is a rendering issue or a text data issue. Feel free to move this issue.
Steps to Reproduce
Visuals
The text was updated successfully, but these errors were encountered: