Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In dynamic locale dialog, some parens in RTL lang are in wrong direction #1379

Closed
liammulh opened this issue Feb 17, 2023 · 13 comments
Closed
Assignees

Comments

@liammulh
Copy link
Member

Test Device

MacBook Air

Operating System

macOS 12.4

Browser

Safari 15.5

Problem Description

Discovered during phetsims/qa#900. In the dynamic locale dialog, the parentheses in one of the Arabic language locales — I think it's ar_MA or Arabic (Morocco) — are in the wrong direction. I believe the parenthesis circled in red below should be an open parenthesis, not a close parenthesis.

I am not sure if this is a rendering issue or a text data issue. Feel free to move this issue.

Steps to Reproduce

  1. Open this link
  2. Open the preferences dialog
  3. Open the localization tab

Visuals

parens2

@samreid
Copy link
Member

samreid commented Feb 18, 2023

In slack, @kathy-phet said:

BLL published in PhET-iO has it right, so I'm not sure why it has it wrong here:
image

@Nancy-Salpepi replied:

I had opened an issue related to ar_MA in BLL.
phetsims/beers-law-lab#326. Maybe that is why?

@samreid
Copy link
Member

samreid commented Feb 18, 2023

There is evidence this is a browser-specific bug. I tested https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.3.0-dev.20/phet-io/circuit-construction-kit-dc_all_phet-io.html?postMessageOnError&phetioStandalone in Chrome and Safari, and saw that Chrome is correct and Safari is incorrect. Here's the screenshot (Chrome on left, Safari on right):

image

May also be related to #1355

@samreid
Copy link
Member

samreid commented Feb 18, 2023

Would it help to call wrapRTL like phetsims/build-a-molecule@8b6bc0c ?

@samreid samreid removed their assignment Feb 18, 2023
@Nancy-Salpepi
Copy link

Actually it is incorrect in published BBL as well with safari. The issue I had opened was for the formulas.
Sorry I didn't catch this.

@matthew-blackman
Copy link
Contributor

@samreid @zepumph @arouinfar and I discussed this, and note that this is not a sim-specific issue.

We would like to reach out to @jonathanolson and @jbphet to provide insight into how this could be solved.

@jonathanolson
Copy link
Contributor

Looking into it. I don't see directional marks in the string for some reason.

@kathy-phet
Copy link

It still works fine on Windows, Chrome.

@jbphet
Copy link
Contributor

jbphet commented Feb 22, 2023

@jonathanolson and I are going to experiment a bit with isolates (see #1355) and see if it makes any different.

@jonathanolson
Copy link
Contributor

Patched above. Browsers were making different guesses for directionality when we didn't have embedding marks in.

@jonathanolson
Copy link
Contributor

@kathy-phet should this be maintenance-patched? I'll patch joist/phetcommon if so.

@liammulh liammulh changed the title In dynamic locale dialog, some parens in LTR lang are in wrong direction In dynamic locale dialog, some parens in RTL lang are in wrong direction Feb 22, 2023
@samreid samreid removed their assignment Feb 24, 2023
@Nancy-Salpepi
Copy link

FYI @samreid: this is fixed in Circuit Construction Kit: DC 1.3.0-rc.1 with mac + safari.

jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/ratio-and-proportion that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/beers-law-lab that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/concentration that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/gravity-and-orbits that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/mean-share-and-balance that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/molecule-shapes that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/number-compare that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/number-play that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/ratio-and-proportion that referenced this issue May 30, 2024
jonathanolson added a commit to phetsims/beers-law-lab that referenced this issue Jun 9, 2024
jonathanolson added a commit to phetsims/concentration that referenced this issue Jun 9, 2024
jonathanolson added a commit to phetsims/gravity-and-orbits that referenced this issue Jun 10, 2024
jonathanolson added a commit to phetsims/mean-share-and-balance that referenced this issue Jun 10, 2024
jonathanolson added a commit to phetsims/molecule-shapes that referenced this issue Jun 10, 2024
jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue Jun 10, 2024
jonathanolson added a commit to phetsims/number-compare that referenced this issue Jun 10, 2024
jonathanolson added a commit to phetsims/number-play that referenced this issue Jun 10, 2024
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue Jun 10, 2024
jonathanolson added a commit to phetsims/ratio-and-proportion that referenced this issue Jun 10, 2024
@jonathanolson
Copy link
Contributor

MR'ed, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants