-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update standard lint rules #1276
Labels
Comments
samreid
added a commit
that referenced
this issue
Jul 11, 2022
samreid
added a commit
to phetsims/perennial
that referenced
this issue
Jul 11, 2022
samreid
added a commit
to phetsims/masses-and-springs
that referenced
this issue
Jul 11, 2022
samreid
added a commit
to phetsims/rosetta
that referenced
this issue
Jul 11, 2022
samreid
added a commit
to phetsims/scenery
that referenced
this issue
Jul 11, 2022
I pushed the revised rules list and proposed fixes for the failing cases. Assigning repo responsible devs or file authors to take a look at the fixes above. |
Looks good, fixed the lazy initialization case in Scenery above (and removed the comment). |
The change to rosetta looks perfectly reasonable to me. Unassigning. |
Thanks, closing. |
zepumph
pushed a commit
to phetsims/perennial
that referenced
this issue
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #1275 we updated to a more recent version of ESLint. A comment in our .eslintrc file says:
However, since https://eslint.org/docs/rules/ has been rearranged, we are out of sync. So it would be good to update this.
Afterwards, it would be good to apply the same philosophy (list all rules, even if marked as "off") to the typescript rules. Heads up to @jessegreenberg that I plan to be working on that soon.
The updated lint rules catch these issues:
I'll commit proposed fixes and assign responsible devs for any necessary review.
The text was updated successfully, but these errors were encountered: