Skip to content

Commit

Permalink
Get rid of AccordionBoxOptions from phet-types.d.ts, phetsims/sun#738
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Mar 2, 2022
1 parent 5ae7c8e commit b956587
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 17 deletions.
2 changes: 1 addition & 1 deletion eslint/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ module.exports = {
NodeOptions: 'readonly',
CanvasNodeOptions: 'readonly',
ThermometerNodeOptions: 'readonly',
AccordionBoxOptions: 'readonly',
ExpandCollapseButtonOptions: 'readonly',
CheckboxOptions: 'readonly',
PanelOptions: 'readonly',
LayoutBoxOptions: 'readonly',
Expand Down
17 changes: 1 addition & 16 deletions phet-types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ type RectangularToggleButtonOptions = {
rightBottomCornerRadius?: number | null;
} & ButtonNodeOptions;

type ExpandCollapseButtonOptions = {} & RectangularToggleButtonOptions;
type ExpandCollapseButtonOptions = RectangularToggleButtonOptions;

type SoundGeneratorOptions = {
initialOutputLevel?: number,
Expand Down Expand Up @@ -185,21 +185,6 @@ class ObservableArray<T> extends Array<T> {
clear() {}
}

// Placeholder until we can use TypeScript in common code
type AccordionBoxOptions = {
titleAlignX?: 'left' | 'right' | 'center',
titleXSpacing?: number,

titleNode?: Node,
contentXMargin?: number,
contentYMargin?: number,
contentYSpacing?: number,
cornerRadius?: number,
buttonXMargin?: number,
buttonYMargin?: number,
expandCollapseButtonOptions?: ExpandCollapseButtonOptions,
} & NodeOptions;

// Placeholder until we can use TypeScript in common code
type ComboBoxItemOptions = Partial<{
soundPlayer: SoundPlayer,
Expand Down

0 comments on commit b956587

Please sign in to comment.