custom lint rules should be linted as node code, #811

eslint/rules/.eslintrc.js

@@ -0,0 +1,10 @@
+// Copyright 2019, University of Colorado Boulder
+// @author Chris Klusendorf
+
+'use strict';
+
+module.exports = {
+
+  // Use all of the default rules from eslint file for node code.
+  "extends": "../node_eslintrc.js"
+};

eslint/rules/bad-sim-text.js

@@ -8,13 +8,16 @@
  * @author Sam Reid (PhET Interactive Simulations)
  * @author Michael Kauzmann (PhET Interactive Simulations)
  */
+
+/* eslint-env node */
+'use strict';
+
 module.exports = function( context ) {
-  'use strict';
 
   const getBadTextTester = require( './getBadTextTester' );
 
   // see getBadTextTester for schema.
-  var forbiddenTextObjects = [
+  const forbiddenTextObjects = [
 
     // babel doesn't support compiling static getters, see https://github.com/phetsims/tasks/issues/983
     { id: ' static get ', codeOnly: true, codeTokens: [ 'static', 'get' ] },

eslint/rules/bad-text.js

@@ -7,8 +7,11 @@
  *
  * @author Sam Reid (PhET Interactive Simulations)
  */
+
+/* eslint-env node */
+'use strict';
+
 module.exports = function( context ) {
-  'use strict';
 
   const getBadTextTester = require( './getBadTextTester' );
 

eslint/rules/copyright.js

@@ -5,12 +5,14 @@
  * @copyright 2015 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   return {
 

eslint/rules/dispose.js

@@ -5,12 +5,14 @@
  * @copyright 2015 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   // the following holds the possible ways to register various PhET listeners and observers
   // TODO: derivedProperty
@@ -38,7 +40,7 @@ module.exports = function( context ) {
           if( OBSERVER_REGISTRATIONS.hasOwnProperty( key ) ) {
             if( calleeName === OBSERVER_REGISTRATIONS[ key ] ) {
               // we have found an observer registration, start at the root and look through its tokens for dispose
-              var disposeFound = false;
+              let disposeFound = false;
               const rootNode = context.getSourceCode().ast;
               if( rootNode &&
                   rootNode.tokens ) {

eslint/rules/getBadTextTester.js

@@ -9,6 +9,9 @@
  * @author Jesse Greenberg (PhET Interactive Simulations)
  */
 
+/* eslint-env node */
+'use strict';
+
 const assert = require( 'assert' );
 
 /**
@@ -17,7 +20,6 @@ const assert = require( 'assert' );
  * @returns {function(node:Object)} - function that reports any bad text lint errors to the context
  */
 module.exports = ( badTexts, context ) => {
-  'use strict';
 
   return node => {
     const sourceCode = context.getSourceCode();

eslint/rules/no-extend.js

@@ -7,8 +7,11 @@
  *
  * @author Michael Kauzmann (PhET Interactive Simulations)
  */
+
+/* eslint-env node */
+'use strict';
+
 module.exports = context => {
-  'use strict';
 
   const badTextParts = [ '_', '.', 'extend' ];
   return {

eslint/rules/no-html-constructors.js

@@ -17,12 +17,14 @@
  * @copyright 2016-2017 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   // names of the native JavaScript constructors that clash with PhET type names
   const nativeConstructors = [ 'Image', 'Range', 'Text', 'Node', 'Event' ];

eslint/rules/no-instanceof-array.js

@@ -5,12 +5,14 @@
  * @copyright 2018 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   return {
     BinaryExpression: function( node ) {

eslint/rules/no-math-sign.js

@@ -5,12 +5,14 @@
  * @copyright 2017 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   return {
 

eslint/rules/no-property-in-require-statement.js

@@ -5,12 +5,14 @@
  * @copyright 2016 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   return {
 

eslint/rules/phet-io-require-contains-ifphetio.js

@@ -5,12 +5,14 @@
  * @copyright 2016 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   return {
 

eslint/rules/phet-object-shorthand.js

@@ -9,11 +9,13 @@
  * original file: https://github.com/eslint/eslint/blob/550de1e611a1e9af873bcb18d74cf2056e8d2e1b/lib/rules/object-shorthand.js
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 module.exports = function( context ) {
-  'use strict';
 
   return {
     'Property:exit'( node ) {

eslint/rules/property-visibility-annotation.js

@@ -6,22 +6,24 @@
  * @copyright 2016 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   return {
 
     AssignmentExpression: function propertyVisibilityAnnotation( node ) {
+      let isAnnotated = false;
 
       if ( node.left && node.left && node.left.object && node.left.object.type === 'ThisExpression' ) {
         const leadingComments = node.parent.leadingComments;
         let i;
         let a;
-        var isAnnotated = false;
         if ( leadingComments ) {
           for ( i = 0; i < leadingComments.length; i++ ) {
             a = leadingComments[ i ];

eslint/rules/require-statement-match.js

@@ -5,12 +5,14 @@
  * @copyright 2015 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   return {
 

eslint/rules/string-require-statement-match.js

@@ -5,12 +5,14 @@
  * @copyright 2015 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 module.exports = function( context ) {
-  'use strict';
 
   // Adapted from Stack Overflow, see http://stackoverflow.com/questions/25085306/javascript-space-separated-string-to-camelcase
   function toCamelCase( string ) {

eslint/rules/todo-should-have-issue.js

@@ -5,8 +5,10 @@
  * @copyright 2015 University of Colorado Boulder
  */
 
+/* eslint-env node */
+'use strict';
+
 module.exports = function( context ) {
-  'use strict';
 
   // Whitelist of directories to check that TODOs have GitHub issues
   const directoriesToRequireIssues = [ /joist[/\\]js/ ];
@@ -17,7 +19,7 @@ module.exports = function( context ) {
 
       // Check whether the given directory matches the whitelist
       let directoryShouldBeChecked = false;
-      for ( var i = 0; i < directoriesToRequireIssues.length; i++ ) {
+      for ( let i = 0; i < directoriesToRequireIssues.length; i++ ) {
         const d = directoriesToRequireIssues[ i ];
         if ( context.getFilename().match( d ) ) {
           directoryShouldBeChecked = true;
@@ -29,7 +31,7 @@ module.exports = function( context ) {
         const comments = context.getSourceCode().getAllComments();
 
         if ( comments ) {
-          for ( i = 0; i < comments.length; i++ ) {
+          for ( let i = 0; i < comments.length; i++ ) {
             const comment = comments[ i ];
 
             if ( comment.value.indexOf( 'TODO' ) >= 0 ) {