Skip to content

Commit

Permalink
Enable parserOptions.project and enable a rule that has no failures, …
Browse files Browse the repository at this point in the history
…see #1238
  • Loading branch information
samreid committed Jul 15, 2022
1 parent 12b052e commit 3a33b83
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions eslint/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ module.exports = {
],
parser: '@typescript-eslint/parser',
parserOptions: {
sourceType: 'module'
sourceType: 'module',

// Provide a tsconfig so that we can use rules that require type information. tsconfig.eslint.json
// gives eslint project information without needing to modify our actual tsconfig setup.
// NOTE: Providing this slows down eslint substantially, see https://github.com/phetsims/chipper/issues/1114#issuecomment-1065927717
// ,project: [ '../chipper/eslint/tsconfig.eslint.json' ]
project: [ '../chipper/eslint/tsconfig.eslint.json' ]
},
plugins: [
'@typescript-eslint'
Expand All @@ -54,7 +54,7 @@ module.exports = {
'@typescript-eslint/array-type': 'off', // We agreed this should be developer preference

// Disallow awaiting a value that is not a Thenable ✅ 💭
'@typescript-eslint/await-thenable': 'off',
'@typescript-eslint/await-thenable': 'error',

// Disallow @ts-<directive> comments or require descriptions after directive ✅
'@typescript-eslint/ban-ts-comment': [ 'off', {
Expand Down

0 comments on commit 3a33b83

Please sign in to comment.