add setTimeout/Interval lint rules, and escape a few usages, phetsims…

…/phet-info#59
phetsims · Nov 8, 2019 · 29b844f · 29b844f
1 parent 89b0a66
commit 29b844f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/eslint/rules/bad-sim-text.js b/eslint/rules/bad-sim-text.js
@@ -42,13 +42,24 @@ module.exports = function( context ) {
     'ptions = _.extend(',
     'onfig = _.extend('
 
+    // In sims, don't allow setTimout and setInterval calls coming from window, see https://github.com/phetsims/phet-info/issues/59
+    // TODO: comment back in when all lint errors are taken care of, https://github.com/phetsims/phet-info/issues/59
+    // {
+    //   id: 'setTimeout(',
+    //   regex: /(window\.| )setTimeout\(/
+    // },
+    // {
+    //   id: 'setInterval(',
+    //   regex: /(window\.| )setInterval\(/
+    // }
+
     // DOT/Util.toFixed or DOT/Util.toFixedNumber should be used instead of toFixed.
     // JavaScript's toFixed is notoriously buggy. Behavior differs depending on browser,
     // because the spec doesn't specify whether to round or floor.
-    // TODO: comment back in when all issues are done, https://github.com/phetsims/chipper/issues/737
+    // TODO: comment back in when all lint errors are taken care of, https://github.com/phetsims/chipper/issues/737
     // {
     //   id: '.toFixed(',     // support regex with english names this way
-    //   regex: new RegExp( '(?<!Util)\\.toFixed\\(' )
+    //   regex: /(?<!Util)\.toFixed\(/
     // }
   ];
 

diff --git a/js/initialize-globals.js b/js/initialize-globals.js
@@ -668,7 +668,7 @@
    * testing a sim for robustness, and allowing others to reproduce slow-behavior bugs.
    */
   window.phet.chipper.makeEverythingSlow = function() {
-    window.setInterval( function() { sleep( 64 ); }, 16 );
+    window.setInterval( function() { sleep( 64 ); }, 16 ); // eslint-disable-line bad-sim-text
   };
   window.phet.chipper.makeRandomSlowness = function() {
     window.setInterval( function() { sleep( Math.ceil( 100 + Math.random() * 200 ) ); }, Math.ceil( 100 + Math.random() * 200 ) ); // eslint-disable-line bad-sim-text