Merge remote-tracking branch 'origin/master'

phetsims · Oct 22, 2019 · 243ddb9 · 243ddb9
2 parents f54332c + 5a88944
commit 243ddb9
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/js/grunt/buildRunnable.js b/js/grunt/buildRunnable.js
@@ -101,6 +101,14 @@ module.exports = async function( repo, minifyOptions, instrument, allHTML, brand
   const thirdPartyEntries = getAllThirdPartyEntries( repo, brand );
   const stringMap = getStringMap( allLocales, phetLibs );
 
+  // If we have NO strings for a given locale that we want, we'll need to fill it in with all English strings, see
+  // https://github.com/phetsims/perennial/issues/83
+  for ( const locale of locales ) {
+    if ( !stringMap[ locale ] ) {
+      stringMap[ locale ] = stringMap[ ChipperConstants.FALLBACK_LOCALE ];
+    }
+  }
+
   const simTitleStringKey = getTitleStringKey( repo );
   const englishTitle = stringMap[ ChipperConstants.FALLBACK_LOCALE ][ simTitleStringKey ];
   assert( englishTitle, `missing entry for sim title, key = ${simTitleStringKey}` );