Skip to content

Commit

Permalink
update TODO to review issue, #1441 phetsims/joist#963
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Kauzmann <[email protected]>
  • Loading branch information
zepumph committed Jun 28, 2024
1 parent d088380 commit 07cf9ee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/data/updateLocaleInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const fs = require( 'fs' );
* You may modify babel/localeData.json file with new locale information. After modifying the file you must take the following steps:
* 1. Run ./updateLocaleInfo.js, so that the automatically generated files are also update
* 2. Notify the responsible developers for rosetta, weddell, yotta, and the website that localeInfo was updated.
* 3. TODO figure out next steps, see https://github.com/phetsims/joist/issues/963
* 3. TODO figure out next steps, see https://github.com/phetsims/chipper/issues/1441
*
* Locale data was originally based on Java's Locale object, but has been modified. Essentially each locale has the
* following data:
Expand Down Expand Up @@ -113,7 +113,7 @@ fs.writeFileSync( './localeInfoModule.js', newModuleSourceCode );

console.log( 'locale info files updated' );

throw new Error( 'NO COMMIT YET, safeguard so we do not commit changes to main yet' ); // TODO: remove for https://github.com/phetsims/joist/issues/963
throw new Error( 'NO COMMIT YET, safeguard so we do not commit changes to main yet' ); // TODO: remove for https://github.com/phetsims/chipper/issues/1441

// eslint-disable-next-line no-unreachable
let needsCommit = false;
Expand Down

0 comments on commit 07cf9ee

Please sign in to comment.