Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosshair mount is incorrect #129

Closed
phet-steele opened this issue Aug 22, 2017 · 5 comments
Closed

Crosshair mount is incorrect #129

phet-steele opened this issue Aug 22, 2017 · 5 comments
Assignees
Labels

Comments

@phet-steele
Copy link
Contributor

Look at the little rectangle that connects the crosshair to the body. In published:

screen shot 2017-08-22 at 12 56 58 pm

But on master and in phetsims/qa/issues/37, it's a circle:
screen shot 2017-08-22 at 12 56 51 pm

The mount is correct once it is dragged out from the toolbox. Seen on macOs 10.12.6 Chrome.

@jonathanolson
Copy link
Contributor

It looks like this may have been purposely added in f412cc0#diff-9106056b55c9f988721c00e7e8a04136 (would be hard to accidentally add two different corner radii parameters without meaning to?)

caf-bit

Is it for-sure a bug?

@phet-steele
Copy link
Contributor Author

Let's investigate!

@phet-steele
Copy link
Contributor Author

@jonathanolson it is not supposed to be there. I can't find documentation on github and @arouinfar also said it "doesn't need to be a dot".

@jonathanolson
Copy link
Contributor

Ok, should be fixed now.

@phet-steele
Copy link
Contributor Author

Beautiful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants