Memory Leak

[KatieWoe]

For phetsims/qa#781. Seen on Win 11 Chrome.
The memory footprint for this sim seems small, but there is a noticeable memory leak. This test was don on the PhET brand sim, with memory snapshots happening one minute apart.

[KatieWoe]

These are the results on the PhET-iO Brand:

[amanda-phet]

This seems important to resolve sooner rather than later

[KatieWoe]

This is in phetsims/qa#789 as well

[jessegreenberg]

The memory leak in phetsims/scenery#1356 has been fixed, but that leak was first introdudced after this issue was first reported. There may still be a memory leak in this sim. The patch to fix the memory leak in AnimatedPanZoomListener is phetsims/scenery@6d4ecc6 for a center-and-variability-1.0 branch of scenery.

[KatieWoe]

The memory leak seems worse in phetsims/qa#795.

[samreid]

Thanks, I pushed a fix for the memory leak. There may be others but that was certainly one. Maybe we should cherry-pick it before release since running the sim for 30 minutes under normal usage seems like it might leak 100MB (if this rate keeps up).

[samreid]

The original fixes had erroneous parts. @chrisklus and I reverted that and applied the correct fix, which is ready for cherry-picking.

[chrisklus]

The change above was cherry-picked for 1.0 publication. This issue may be ready to close, but for now I'm going to move to 1.1 milestone so a more careful delta comparison is completed before closing.

[samreid]

There is another memory leak in

center-and-variability/js/common/view/CAVPlotNode.ts

Lines 105 to 124 in e0611ff

	const map = new Map<CAVObject, CAVObjectNode>();
	const createDotNode = ( casObject: CAVObject ) => {
	const dotNode = dotNodeGroup.createCorrespondingGroupElement( casObject.tandem.name, casObject );
	casObject.valueProperty.link( value => {
	dotNode.setVisible( value !== null );
	if ( value !== null && !this.dotLayer.hasChild( dotNode ) ) {
	this.dotLayer.addChild( dotNode );
	}
	} );
	map.set( casObject, dotNode );
	};
	model.objectGroup.forEach( createDotNode );
	model.objectGroup.elementCreatedEmitter.addListener( createDotNode );
	model.objectGroup.elementDisposedEmitter.addListener( casObject => {
	const viewNode = map.get( casObject )!;
	dotNodeGroup.disposeElement( viewNode );
	} );

[chrisklus]

@samreid and I added in the missing delete for the dots in the commit above. We tested by printing the map size and it's working as expected, marking for cherry-pick.

After making the next for RC the maintenance release, we think it would be good to have QA do 5-10 min of spot check testing (normal sim use/testing) to sign off that this is good to go.

[chrisklus]

@samreid and I deployed these changes for version 1.0.1, closing.