Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On the variability screen, show the player after all kicks have been kicked #328

Closed
samreid opened this issue Jun 27, 2023 · 4 comments
Closed

On the variability screen, show the player after all kicks have been kicked #328

samreid opened this issue Jun 27, 2023 · 4 comments
Assignees
@marlitas @matthew-blackman
Labels
status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Jun 27, 2023

Like this

image

No soccer ball and no buttons though. Great idea @matthew-blackman
@matthew-blackman matthew-blackman mentioned this issue Jul 6, 2023
Closed
matthew-blackman added a commit that referenced this issue Jul 10, 2023
@matthew-blackman
Show last player when done kicking if no players left - see #328
2777dee
@matthew-blackman
Copy link
Contributor

This is ready for design review @catherinecarter 😃

Can you double check the following?

  • All screens show the correct players for all values of maxKicks
  • All screens show the correct behavior when players are done kicking

@catherinecarter
Copy link
Contributor

Checked all screens and all Max Kicks. Looks good!

matthew-blackman added a commit that referenced this issue Jul 11, 2023
@matthew-blackman
Add documentation - see #328
bd41004
@matthew-blackman
Copy link
Contributor

This is ready for review @marlitas, possibly as part of #327.

matthew-blackman added a commit that referenced this issue Jul 11, 2023
@matthew-blackman
Fix typo - see #328
57b66f7
@matthew-blackman
Copy link
Contributor

Implemented and documented. Closing.

marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
@matthew-blackman
Show last player when done kicking if no players left - see phetsims/…
3811bc3 
…center-and-variability#328
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
@matthew-blackman
Add documentation - see phetsims/center-and-variability#328
ddf2748
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
@matthew-blackman
Fix typo - see phetsims/center-and-variability#328
357f4c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlitas marlitas

@matthew-blackman matthew-blackman

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @marlitas @matthew-blackman @catherinecarter