Problems on Reset

[samreid]

Sim can get frozen.

card arrow can show over nothingness

[samreid]

One time after resetting there was a leftover card in the card panel

[samreid]

Something like this may help with that unresetted card:

Subject: [PATCH] Clear card cells on inactive, see https://github.com/phetsims/center-and-variability/issues/172
---
Index: js/median/view/CardNodeContainer.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/median/view/CardNodeContainer.ts b/js/median/view/CardNodeContainer.ts
--- a/js/median/view/CardNodeContainer.ts	(revision 6e8d554607922202e5631e08fba478dc76a69a6b)
+++ b/js/median/view/CardNodeContainer.ts	(date 1683383199141)
@@ -207,8 +207,22 @@
         }
         else if ( !isActive ) {
           const index = this.cardNodeCells.indexOf( cardNode );
-          this.cardNodeCells.splice( index, 1 );
-          this.cardNodeCellsChangedEmitter.emit();
+
+          if ( index >= 0 ) {
+            this.cardNodeCells.splice( index, 1 );
+            this.cardNodeCellsChangedEmitter.emit();
+          }
+        }
+      } );
+
+      cardModel.soccerBall.valueProperty.link( value => {
+        if ( value === null ) {
+          const index = this.cardNodeCells.indexOf( cardNode );
+
+          if ( index >= 0 ) {
+            this.cardNodeCells.splice( index, 1 );
+            this.cardNodeCellsChangedEmitter.emit();
+          }
         }
       } );
 

[samreid]

Fixed in the commit, with one TODO for discussion.

[samreid]

Can't test this until #189 is fixed. So perhaps I'll increase its priority.

[samreid]

Reset seems pretty nice in my testing. @marlitas or @matthew-blackman want to review/test?

[marlitas]

Played around with some different scenarios and I am not seeing any remaining issues related to reset functionality. Commits are small, and seem appropriate. No concerns here. Ready to close if @samreid is.

[samreid]

Thanks! Closing.

[phet-dev]

Reopening because there is a TODO marked for this issue.

[samreid]

I could use help on the remaining TODO.

[matthew-blackman]

@samreid and I tested the behavior without the dragPositionProperty being reset, and found no issues. The valueProperty of the soccerBall is now being reset correctly. We feel that this issue can be closed.