Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccordionBox layout (info button and dot plot) #166

Closed
marlitas opened this issue May 2, 2023 · 3 comments
Closed

AccordionBox layout (info button and dot plot) #166

marlitas opened this issue May 2, 2023 · 3 comments
Labels
priority:2-high

Comments

@marlitas
Copy link
Contributor

marlitas commented May 2, 2023

We created phetsims/sun#843 in sun, because we would like to remove this line of hacky code in CAVAccordionBox:

    backgroundNode.localBounds = backgroundNode.localBounds.copy();

This code currently provides a workaround that allows us to render the info button and dot plot points on top of the titleNode in AccordionBox
@marlitas marlitas mentioned this issue May 4, 2023
Closed
@samreid
Copy link
Member

samreid commented May 4, 2023

Closing as duplicate of #170

@samreid samreid closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
@samreid
Copy link
Member

samreid commented May 5, 2023

Reopening because there is a TODO marked for this issue.

@samreid samreid reopened this May 5, 2023
samreid added a commit that referenced this issue May 5, 2023
@samreid
Redirect TODO issue, see #166
2ecc100
@samreid samreid mentioned this issue May 5, 2023
Closed
@samreid
Copy link
Member

samreid commented May 6, 2023

Closing, we will work on this in #170

@samreid samreid closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:2-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @marlitas