Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

?phetioDebug won't run in Studio #100

Closed
KatieWoe opened this issue Mar 22, 2022 · 5 comments
Closed

?phetioDebug won't run in Studio #100

KatieWoe opened this issue Mar 22, 2022 · 5 comments
Labels
dev:phet-io status:ready-to-cherry-pick type:bug Something isn't working
Milestone
Publish 1.0 as a ...

Comments

@KatieWoe
Copy link

For phetsims/qa#789. Seen on Win 11 Chrome.
When trying to run studio with the ?phetioDebug parameter, I got the below error and studio would not load.
debugpopup
@KatieWoe KatieWoe added the type:bug Something isn't working label Mar 22, 2022
@KatieWoe
Copy link
Author

The same seems to happen in the state wrapper:
similarstate

@chrisklus
Copy link
Contributor

@samreid and I identified two steps for this issue:

  1. Related to Unable to open example sim #99 - marking SoccerPlayers as phetioDynamicElement: true. And other possible errors from phet-io debug, like missing required tandems.
  2. Making a phet-io issue to investigate why some modes of running the sim (phetioDebug) identify these errors, and others do not.

@chrisklus chrisklus added this to the Classroom prototype milestone Mar 28, 2022
samreid added a commit that referenced this issue Mar 28, 2022
@samreid
Enable validation, supply tandems, specify phetioDynamicElement: true…
6d2281b 
…, see #99 and #100
samreid added a commit that referenced this issue Mar 28, 2022
@samreid
Specify tandems, see #100
a7bb448
@samreid
Copy link
Member

samreid commented Mar 28, 2022

This seems fixed after the commits. @KatieWoe can you please verify on phettest? If all is well, please relabel as "ready for cherry pick".

@samreid samreid assigned KatieWoe and unassigned samreid and chrisklus Mar 28, 2022
@KatieWoe
Copy link
Author

?phetioDebug seems to be included automatically in master, and both studio and state loaded fine.

@KatieWoe KatieWoe assigned samreid and unassigned KatieWoe Mar 29, 2022
@samreid
Copy link
Member

samreid commented Apr 6, 2022

@chrisklus and I confirmed this is fixed in in #122, closing.

@samreid samreid closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:phet-io status:ready-to-cherry-pick type:bug Something isn't working
Projects
None yet
Milestone
Publish 1.0 as a prototype
Development

No branches or pull requests
3 participants
@samreid @chrisklus @KatieWoe