Allow interval tool to be dragged 0..16, see #194

phetsims · May 12, 2023 · ce7732a · ce7732a
1 parent 59342b3
commit ce7732a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/js/common/CAVConstants.ts b/js/common/CAVConstants.ts
@@ -58,6 +58,7 @@ const CAVConstants = {
   },
 
   PHYSICAL_RANGE: new Range( 1, 15 ),
+  VARIABILITY_DRAG_RANGE: new Range( 0, 16 ),
   MAX_KICKS_VALUES: [ 15, 20, 25, 30 ],
 
   // TODO: I added to the height while the title bar doesn't allow overlap, see https://github.com/phetsims/center-and-variability/issues/170

diff --git a/js/variability/model/VariabilityModel.ts b/js/variability/model/VariabilityModel.ts
@@ -78,11 +78,11 @@ export default class VariabilityModel extends CAVModel {
     } );
 
     this.intervalTool1ValueProperty = new NumberProperty( 2, {
-      range: CAVConstants.PHYSICAL_RANGE,
+      range: CAVConstants.VARIABILITY_DRAG_RANGE,
       tandem: options.tandem.createTandem( 'intervalTool1ValueProperty' )
     } );
     this.intervalTool2ValueProperty = new NumberProperty( 3, {
-      range: CAVConstants.PHYSICAL_RANGE,
+      range: CAVConstants.VARIABILITY_DRAG_RANGE,
       tandem: options.tandem.createTandem( 'intervalTool2ValueProperty' )
     } );
   }

diff --git a/js/variability/view/VariabilityScreenView.ts b/js/variability/view/VariabilityScreenView.ts
@@ -54,7 +54,7 @@ export default class VariabilityScreenView extends CAVScreenView {
 
     super( model, options );
 
-    this.contentLayer.addChild( new PredictionSlider( model.intervalTool1ValueProperty, this.modelViewTransform, CAVConstants.PHYSICAL_RANGE, {
+    this.contentLayer.addChild( new PredictionSlider( model.intervalTool1ValueProperty, this.modelViewTransform, CAVConstants.VARIABILITY_DRAG_RANGE, {
       predictionThumbNodeOptions: {
         color: CAVColors.intervalToolIconShadedSphereMainColorProperty
       },
@@ -65,7 +65,7 @@ export default class VariabilityScreenView extends CAVScreenView {
       tandem: options.tandem.createTandem( 'variabilityIntervalPredictionTool1ValueNode' )
     } ) );
 
-    this.contentLayer.addChild( new PredictionSlider( model.intervalTool2ValueProperty, this.modelViewTransform, CAVConstants.PHYSICAL_RANGE, {
+    this.contentLayer.addChild( new PredictionSlider( model.intervalTool2ValueProperty, this.modelViewTransform, CAVConstants.VARIABILITY_DRAG_RANGE, {
       predictionThumbNodeOptions: {
         color: CAVColors.intervalToolIconShadedSphereMainColorProperty
       },