Skip to content

Commit

Permalink
Update TODOs, see #6
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Feb 2, 2022
1 parent 9c749e9 commit c666db3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions js/common/CASScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import CASModel from './model/CASModel.js';
import CASScreenView from './view/CASScreenView.js';
import { PhetioObjectOptions } from '../../../tandem/js/PhetioObject.js';

// type CASScreenOptions = ScreenOptions; //TODO
export type CASScreenOptions = PhetioObjectOptions & Required<Pick<PhetioObjectOptions, 'tandem'>>;

// TODO: Can we delete this file or does it provide value???
Expand All @@ -25,7 +24,7 @@ class CASScreen extends Screen {
constructor( createModel: () => CASModel, createView: ( m: CASModel ) => CASScreenView, providedOptions?: CASScreenOptions ) {

const options = optionize<CASScreenOptions>( {
//TODO if you include homeScreenIcon or navigationBarIcon, use JOIST/ScreenIcon
// TODO if you include homeScreenIcon or navigationBarIcon, use JOIST/ScreenIcon
backgroundColorProperty: CASColors.screenBackgroundColorProperty,

// phet-io options
Expand Down
1 change: 0 additions & 1 deletion js/common/view/BackgroundNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import Property from '../../../../axon/js/Property.js';
import Bounds2 from '../../../../dot/js/Bounds2.js';
import CASColors from '../CASColors.js';

// TODO: Do we still want a separate node for Sky and Ground?
class BackgroundNode extends Rectangle {
constructor( bottomY: number, visibleBoundsProperty: Property<Bounds2> ) {
super( visibleBoundsProperty.value.centerX, visibleBoundsProperty.value.top, visibleBoundsProperty.value.centerX, bottomY );
Expand Down

0 comments on commit c666db3

Please sign in to comment.