Skip to content

Commit

Permalink
self options defaults to providedOptions instead of {}, and add {} as…
Browse files Browse the repository at this point in the history
… self options in usages, phetsims/phet-core#105
  • Loading branch information
zepumph committed Feb 24, 2022
1 parent 4f1b769 commit 8f3f3da
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion js/common/view/QuestionBar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class QuestionBar extends StatusBar {

constructor( layoutBounds: Bounds2, boundsProperty: Property<Bounds2>, providedOptions: QuestionBarOptions ) {

const options = optionize<QuestionBarOptions>( {
const options = optionize<QuestionBarOptions, {}>( {
floatToTop: true,
barHeight: 70
}, providedOptions );
Expand Down
2 changes: 1 addition & 1 deletion js/lab/LabScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class LabScreen extends CASScreen<LabModel, LabScreenView> {

constructor( providedOptions: LabScreenOptions ) {

const options = optionize<LabScreenOptions>( {
const options = optionize<LabScreenOptions, {}>( {
name: centerAndSpreadStrings.screen.lab,
backgroundColorProperty: CASColors.screenBackgroundColorProperty,
tandem: Tandem.REQUIRED
Expand Down
2 changes: 1 addition & 1 deletion js/mean-and-median/MeanAndMedianScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class MeanAndMedianScreen extends CASScreen<MeanAndMedianModel, MeanAndMedianScr

constructor( providedOptions: MeanAndMedianScreenOptions ) {

const options = optionize<MeanAndMedianScreenOptions>( {
const options = optionize<MeanAndMedianScreenOptions, {}>( {
name: centerAndSpreadStrings.screen.meanAndMedian,
backgroundColorProperty: CASColors.screenBackgroundColorProperty,
tandem: Tandem.REQUIRED
Expand Down
2 changes: 1 addition & 1 deletion js/median/MedianScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class MedianScreen extends CASScreen<MedianModel, MedianScreenView> {

constructor( providedOptions: MedianScreenOptions ) {

const options = optionize<MedianScreenOptions>( {
const options = optionize<MedianScreenOptions, {}>( {
name: centerAndSpreadStrings.screen.median,
backgroundColorProperty: CASColors.screenBackgroundColorProperty,
tandem: Tandem.REQUIRED
Expand Down
2 changes: 1 addition & 1 deletion js/spread/SpreadScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class SpreadScreen extends CASScreen<SpreadModel, SpreadScreenView> {

constructor( providedOptions: SpreadScreenOptions ) {

const options = optionize<SpreadScreenOptions>( {
const options = optionize<SpreadScreenOptions, {}>( {
name: centerAndSpreadStrings.screen.spread,
backgroundColorProperty: CASColors.screenBackgroundColorProperty,
tandem: Tandem.REQUIRED
Expand Down

0 comments on commit 8f3f3da

Please sign in to comment.