Address TODO, see: #164

phetsims · May 12, 2023 · 7ab2d68 · 7ab2d68
1 parent 8a62816
commit 7ab2d68
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/js/common/CAVConstants.ts b/js/common/CAVConstants.ts
@@ -68,7 +68,9 @@ const CAVConstants = {
   MAX_KICKS_PROPERTY: new NumberProperty( CAVQueryParameters.maxKicks, {
     validValues: [ 15, 20, 25, 30 ],
     tandem: Tandem.PREFERENCES.createTandem( 'maxKicksProperty' )
-  } )
+  } ),
+
+  SCENE_VIEW_TANDEM: 'sceneView'
 };
 
 centerAndVariability.register( 'CAVConstants', CAVConstants );

diff --git a/js/common/view/CAVScreenView.ts b/js/common/view/CAVScreenView.ts
@@ -103,7 +103,7 @@ export default class CAVScreenView extends ScreenView {
       ( soccerPlayer, sceneModel ) => this.getSoccerPlayerImageSet( soccerPlayer, sceneModel ),
       modelViewTransform,
       this.visibleBoundsProperty, {
-        tandem: options.tandem.createTandem( 'sceneView' + index )
+        tandem: options.tandem.createTandem( CAVConstants.SCENE_VIEW_TANDEM + index )
       } ) );
 
     const createToggleNode = ( pickLayer: ( sceneView: SceneView ) => Node ) => new ToggleNode( model.selectedSceneModelProperty, this.sceneViews.map( sceneView => {

diff --git a/js/variability/view/VariabilityScreenView.ts b/js/variability/view/VariabilityScreenView.ts
@@ -120,9 +120,11 @@ export default class VariabilityScreenView extends CAVScreenView {
 
     model.variabilitySceneModels.forEach( ( sceneModel, index ) => {
 
-      // TODO: https://github.com/phetsims/center-and-variability/issues/164 Do we really want to create 12 of these?
+      // The infoDialog only exists in the VariabilityScreen, so having CAVScreenView be in charge of creating custom subclasses
+      // of CAVSceneView is overcomplicated and unnecessary. Instead, we create an equivalent tandem, so that it will appear
+      // under the appropriate sceneView in the studio tree.
       const infoDialog = new InfoDialog( model, sceneModel, {
-        tandem: options.tandem.createTandem( 'scene' + index ).createTandem( 'infoDialog' )
+        tandem: options.tandem.createTandem( CAVConstants.SCENE_VIEW_TANDEM + index ).createTandem( 'infoDialog' )
       } );
 
       Multilink.multilink( [ model.isInfoVisibleProperty, sceneModel.isVisibleProperty ],