Skip to content

Commit

Permalink
Move TODOs, see #170 and #201
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed May 13, 2023
1 parent a7e9969 commit 2c0ada5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion js/variability/view/VariabilityAccordionBox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export default class VariabilityAccordionBox extends CAVAccordionBox {
const madValueProperty = deriveValueProperty( vsm => vsm.madValueProperty );
const meanValueProperty = deriveValueProperty( vsm => vsm.meanValueProperty );

// TODO: Why can't this infer the type parameter? See https://github.com/phetsims/center-and-variability/issues/170
// TODO: Why can't this infer the type parameter? See https://github.com/phetsims/center-and-variability/issues/201
const readoutsToggleNode = new ToggleNode<VariabilityMeasure>( model.selectedVariabilityProperty, [ {
value: VariabilityMeasure.RANGE,
tandemName: 'rangeReadoutToggleNode',
Expand Down
2 changes: 1 addition & 1 deletion js/variability/view/VariabilityPlotNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default class VariabilityPlotNode extends Node {
public constructor( model: VariabilityModel, sceneModel: VariabilitySceneModel, providedOptions: CAVPlotOptions ) {
super( providedOptions );

// TODO: Why can't it infer reasonable types here? See https://github.com/phetsims/center-and-variability/issues/170
// TODO: Why can't it infer reasonable types here? See https://github.com/phetsims/center-and-variability/issues/201
const toggleNode = new ToggleNode<VariabilityMeasure, CAVPlotNode>( model.selectedVariabilityProperty, [ {
createNode: tandem => new RangeNode( model, sceneModel, {
parentContext: 'accordion',
Expand Down

0 comments on commit 2c0ada5

Please sign in to comment.