Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT x position cannot be zero #69

Closed
KatieWoe opened this issue Oct 6, 2022 · 3 comments
Closed

CT x position cannot be zero #69

KatieWoe opened this issue Oct 6, 2022 · 3 comments

Comments

@KatieWoe
Copy link

KatieWoe commented Oct 6, 2022

calculus-grapher : multitouch-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1665054011867/calculus-grapher/calculus-grapher_en.html?continuousTest=%7B%22test%22%3A%5B%22calculus-grapher%22%2C%22multitouch-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1665054011867%22%2C%22timestamp%22%3A1665061543831%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Uncaught Error: Assertion failed: x position cannot be zero
Error: Assertion failed: x position cannot be zero
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1665054011867/assert/js/assert.js:28:13)
at assert (OriginalCurve.ts:187:14)
at tiltToPosition (OriginalCurveNode.ts:91:16)
at _dragListener (PressListener.ts:528:9)
at call (DragListener.ts:309:35)
at apply (PhetioAction.ts:124:16)
at execute (DragListener.ts:460:21)
at drag (PressListener.ts:897:13)
at inputEvent (Input.ts:1804:91)
at dispatchToListeners (Input.ts:1755:9)
id: Bayes Puppeteer
Snapshot from 10/6/2022, 5:00:11 AM

----------------------------------

calculus-grapher : pan-and-zoom-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1665054011867/calculus-grapher/calculus-grapher_en.html?continuousTest=%7B%22test%22%3A%5B%22calculus-grapher%22%2C%22pan-and-zoom-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1665054011867%22%2C%22timestamp%22%3A1665058552549%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Uncaught Error: Assertion failed: x position cannot be zero
Error: Assertion failed: x position cannot be zero
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1665054011867/assert/js/assert.js:28:13)
at assert (OriginalCurve.ts:187:14)
at tiltToPosition (OriginalCurveNode.ts:91:16)
at _dragListener (PressListener.ts:528:9)
at call (DragListener.ts:309:35)
at apply (PhetioAction.ts:124:16)
at execute (DragListener.ts:460:21)
at drag (PressListener.ts:897:13)
at inputEvent (Input.ts:1804:91)
at dispatchToListeners (Input.ts:1755:9)
id: Bayes Puppeteer
Snapshot from 10/6/2022, 5:00:11 AM

----------------------------------

calculus-grapher : phet-io-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1665054011867/calculus-grapher/calculus-grapher_en.html?continuousTest=%7B%22test%22%3A%5B%22calculus-grapher%22%2C%22phet-io-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1665054011867%22%2C%22timestamp%22%3A1665059791805%7D&ea&brand=phet-io&phetioStandalone&fuzz&memoryLimit=1000
Query: ea&brand=phet-io&phetioStandalone&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: x position cannot be zero
Error: Assertion failed: x position cannot be zero
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1665054011867/assert/js/assert.js:28:13)
at assert (OriginalCurve.ts:187:14)
at tiltToPosition (OriginalCurveNode.ts:91:16)
at _dragListener (PressListener.ts:528:9)
at call (DragListener.ts:309:35)
at apply (PhetioAction.ts:124:16)
at execute (DragListener.ts:460:21)
at drag (PressListener.ts:897:13)
at inputEvent (Input.ts:1804:91)
at dispatchToListeners (Input.ts:1755:9)
id: Bayes Puppeteer
Snapshot from 10/6/2022, 5:00:11 AM
@veillette
Copy link
Contributor

I recently added dragBound to the drag listener. I suspect it may be related to it.

@samreid
Copy link
Member

samreid commented Oct 8, 2022

I added a guard for now, not sure if that is the best long term solution though. Tagging for phetsims/tasks#1106

@veillette
Copy link
Contributor

Sam correctly identified the issue. CT has been quiet since. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants