Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Calculus Grapher from phet-io-state-unsupported #50

Closed
veillette opened this issue Sep 20, 2022 · 2 comments
Closed

Remove Calculus Grapher from phet-io-state-unsupported #50

veillette opened this issue Sep 20, 2022 · 2 comments
Assignees
@veillette
Labels
dev:phet-io priority:5-deferred

Comments

@veillette
Copy link
Contributor

veillette commented Sep 20, 2022 •
edited
Loading

We have added calculus-grapher to phet-io-state-unsupported. We should remove it in the long run as we wish to instrument this simulation (#48). This issue will ensure that we remove it from the list prior. to publication
@veillette veillette self-assigned this Sep 20, 2022
veillette added a commit to phetsims/perennial that referenced this issue Sep 20, 2022
@veillette
adding calculus-grapher (see phetsims/calculus-grapher#50)
2ecba1a 
Signed-off-by: Martin Veillette <[email protected]>
@veillette veillette changed the title Remove Calculus Graphics from phet-io-state-unsupported Remove Calculus Grapher from phet-io-state-unsupported Oct 2, 2022
@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 6, 2022 •
edited
Loading

12/6/2022 @veillette and I considered whether to enable this yet. Decided to wait until the sim is close to feature complete, and after we've had a chance to do a thorough review of the PhET-iO instrumentation.

@pixelzoom
Copy link
Contributor

I moved this task to #209 (PhET-iO post-review checklist). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veillette veillette

Labels
dev:phet-io priority:5-deferred
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @veillette