Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer areas sign-off #267

Closed
pixelzoom opened this issue Mar 8, 2023 · 2 comments
Closed

Pointer areas sign-off #267

pixelzoom opened this issue Mar 8, 2023 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Mar 8, 2023

For #262.

We'll need to get this from @amanda-phet before QA testing begins (3/20).

I think we're in good shape here, but I'll have a look before assigning to @amanda-phet.

@pixelzoom
Copy link
Contributor Author

@amanda-phet this is ready for review.

Note that there's one place where touch areas overlap a bit -- when the reference line scrubber and area scrubber (or tangent scrubber) are at the same x location. See screenshot below. We feel that this is acceptable.

screenshot_2382

@pixelzoom pixelzoom assigned amanda-phet and unassigned pixelzoom Mar 8, 2023
@pixelzoom pixelzoom mentioned this issue Mar 8, 2023
76 tasks
@pixelzoom pixelzoom changed the title Point areas sign-off Pointer areas sign-off Mar 9, 2023
@amanda-phet
Copy link
Contributor

Pointer areas look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants