Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish tick marks on barometer #159

Closed
amanda-phet opened this issue Jan 5, 2023 · 8 comments
Closed

Polish tick marks on barometer #159

amanda-phet opened this issue Jan 5, 2023 · 8 comments
Assignees

Comments

@amanda-phet
Copy link
Contributor

Discussed 1/5/23

  • Sum of area could go by 50s instead of 40s
  • Consider reducing weight (or number) of intermediate tick marks
  • Consider only having tick marks on the left side and not overlapping with the bar
@veillette
Copy link
Contributor

There are numerous changes below

The minor tick marks are set to gray, and I halved their linewidth. There are fewer major tick marks. I also reduced the font size of the values.

@veillette
Copy link
Contributor

veillette commented Jan 10, 2023

I created an issue to support non-symmetric tick marks in Bamboo (our common-code charting library) as it is not possible to do at present time.

veillette added a commit that referenced this issue Jan 10, 2023
@pixelzoom
Copy link
Contributor

Looking good!

@catherinecarter
Copy link

Looks great! I'm wondering if using fewer minor tick marks would be sufficient. With three tick marks between major tick marks of size 50 makes it challenging to calculate the increment. Perhaps one minor tick mark to mark 25 would be sufficient. I'd have to see it, but I suspect it might be ok.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 10, 2023

Here's what I see in master...

For Slope, major tick spacing of 5 seems nice, as does minor tick spacing of 1.
screenshot_2138

For Area, I'm not sure what @catherinecarter is reporting. I see major tick spacing of 100 (not 50), and the minor tick spacing of 25 seems fine.
screenshot_2137

So these both look great to me.

@catherinecarter
Copy link

Oh! Great! I think Martin may have changed it between me looking and then having meetings and now. Looks great :)

@amanda-phet
Copy link
Contributor Author

What you have in screenshots here @pixelzoom looks great to me.

@amanda-phet amanda-phet removed their assignment Jan 10, 2023
@veillette
Copy link
Contributor

From that last messages, I think it is safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants