rename getChartBounds to getChartRectangleBounds, #259, #304

phetsims · Mar 22, 2023 · 9f8941c · 9f8941c
1 parent d589c69
commit 9f8941c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/js/common/view/GraphNode.ts b/js/common/view/GraphNode.ts
@@ -184,7 +184,7 @@ export default class GraphNode extends Node {
         stroke: graphType.strokeProperty,
         discontinuousPointsFill: options.chartRectangleOptions.fill!,
         plotBoundsMethod: CalculusGrapherConstants.PLOT_BOUNDS_METHOD, // see https://github.com/phetsims/calculus-grapher/issues/210
-        plotBounds: this.getChartBounds(), // see https://github.com/phetsims/calculus-grapher/issues/259
+        plotBounds: this.getChartRectangleBounds(), // see https://github.com/phetsims/calculus-grapher/issues/259
         tandem: providedOptions.tandem.createTandem( 'curveNode' )
       } );
     }
@@ -334,7 +334,7 @@ export default class GraphNode extends Node {
     } );
   }
 
-  protected getChartBounds(): Bounds2 {
+  protected getChartRectangleBounds(): Bounds2 {
     return this.chartRectangle.getShape().bounds;
   }
 

diff --git a/js/common/view/OriginalGraphNode.ts b/js/common/view/OriginalGraphNode.ts
@@ -113,7 +113,7 @@ export default class OriginalGraphNode extends GraphNode {
         lineWidth: 3 // see https://github.com/phetsims/calculus-grapher/issues/205
       },
       plotBoundsMethod: CalculusGrapherConstants.PLOT_BOUNDS_METHOD, // see https://github.com/phetsims/calculus-grapher/issues/210
-      plotBounds: this.getChartBounds(), // see https://github.com/phetsims/calculus-grapher/issues/259
+      plotBounds: this.getChartRectangleBounds(), // see https://github.com/phetsims/calculus-grapher/issues/259
       isInteractiveProperty: DerivedProperty.not( predictEnabledProperty ),
       visibleProperty: new DerivedProperty(
         [ predictEnabledProperty, this.showOriginalCurveProperty ],
@@ -135,7 +135,7 @@ export default class OriginalGraphNode extends GraphNode {
       stroke: CalculusGrapherColors.predictCurveStrokeProperty,
       discontinuousPointsFill: options.chartRectangleOptions.fill!,
       plotBoundsMethod: CalculusGrapherConstants.PLOT_BOUNDS_METHOD, // see https://github.com/phetsims/calculus-grapher/issues/210
-      plotBounds: this.getChartBounds(), // see https://github.com/phetsims/calculus-grapher/issues/259
+      plotBounds: this.getChartRectangleBounds(), // see https://github.com/phetsims/calculus-grapher/issues/259
       isInteractiveProperty: predictEnabledProperty,
       visibleProperty: predictEnabledProperty,
       tandem: options.tandem.createTandem( 'predictCurveNode' )