Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Screen: Lab #113

Closed
DianaTavares opened this issue Mar 1, 2024 · 9 comments
Closed

New Screen: Lab #113

DianaTavares opened this issue Mar 1, 2024 · 9 comments

Comments

@DianaTavares
Copy link

DianaTavares commented Mar 1, 2024

This new screen goes between Explore and Shapes.

This is its initial state:
image

Fluid displaced
When "Fluid displaced" is selected, a beaker panel will appear in the position shown in the next picture (between the forces panel and the ground:
image

I want the panel to have the same color that the other panels, but the scale color needs to be darker. I couldn't do that in the mock-up, but I hope you can be in the code.

The fluid pool volume is 100L, then the beaker will fill with fluid with the operation: the value of fluid pool volume — 100L. The max volume of the breaker is 10L, and then it has tick marks every 1 L, with a bigger tick mark in 5 and 10L. The color of the fluid inside needs to match the fluid in the pool.

Sale in the fluid
The scale can move only in the vertical direction with a control like a slider
image

The movement goes from the bottom, to the surface (it can't go out of the pool or affect the Fluid displaced measurement)
image

% submerged panel
When % submerged (#112 ) is active, the panel will be placed in the bottom of the density panel:
image

Scale on the ground
make it unmovable. We don't want that users move in the pool.

Icon
This is the icon, but I hope that by drawing it with code looks much better! Use the same scale that the screens, only showing N (units).

image

zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 5, 2024
zepumph added a commit that referenced this issue Mar 5, 2024
zepumph added a commit to phetsims/babel that referenced this issue Mar 5, 2024
@zepumph
Copy link
Member

zepumph commented Mar 5, 2024

Scaffolding committed. Right now it is a direct copy of Applications.

@zepumph
Copy link
Member

zepumph commented Mar 6, 2024

  • Make sure custom range goes all the way to 27 for the block mass.

@zepumph
Copy link
Member

zepumph commented Mar 11, 2024

  • Do we want the "A" label on the block? Probably not.
  • Do we want to support the mystery materials like in the explore screen?

zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 11, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 11, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 11, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 11, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 11, 2024
@zepumph
Copy link
Member

zepumph commented Mar 11, 2024

Lots of work still to do here, but I made a commit for the displaced fluid panel (currently invisible). I'll get back to things tomorrow.

zepumph added a commit to phetsims/density that referenced this issue Mar 12, 2024
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/babel that referenced this issue Mar 15, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 15, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 15, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 15, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 15, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 15, 2024
zepumph added a commit to phetsims/scenery-phet that referenced this issue Mar 15, 2024
@zepumph
Copy link
Member

zepumph commented Mar 15, 2024

Good progress here today, but definitely not done here, but here is the current fluid displaced panel:

image

More to be done next week. (including 4 TODOs)

zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 26, 2024
@zepumph
Copy link
Member

zepumph commented Mar 26, 2024

Making progress:
image

zepumph added a commit to phetsims/axon that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 27, 2024
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/axon that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/scenery-phet that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 27, 2024
@zepumph
Copy link
Member

zepumph commented Mar 27, 2024

I finished the design of the fluid displaced panel, and created #129 for @DianaTavares to look at. I'll continue on with other items here.

zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Apr 5, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Apr 5, 2024
@zepumph zepumph mentioned this issue Apr 5, 2024
@zepumph
Copy link
Member

zepumph commented Apr 5, 2024

Hey @DianaTavares! @samreid and I believe that this issue is ready for review. Almost everything has been implemented, and remaining work is over in side issues:

Sticky scale component (totally not working right now): phetsims/density-buoyancy-common#107
Screen icon: #48

Can you take a look at the screen and let me know if there is anything you'd like changed? The only main difference from the mockup is that there is no "A" label, since there isn't a "B" block to add in.

@DianaTavares
Copy link
Author

It is amazing!! in the last design meeting, we agreed to change the "gravity control" to a new place, but I created an issue with those changes in #133
image

Then we can close this issue. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants