Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to hide the stable/unstable checkbox #224

Open
zepumph opened this issue Mar 3, 2021 · 4 comments
Open

Add the ability to hide the stable/unstable checkbox #224

zepumph opened this issue Mar 3, 2021 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 3, 2021

From https://github.com/phetsims/special-ops/issues/189, we need to be able to hide this checkbox. While I could create an entire wrapper over in https://github.com/phetsims/special-ops/issues/189 just to toggle a visibleProperty, I think it is much easier and more maintainable to create a query parameter to achieve the same thing.

Matching priority of the parent issue.

@zepumph
Copy link
Member Author

zepumph commented Mar 3, 2021

@jbphet would you please review this change. What do you think?

@jbphet
Copy link
Contributor

jbphet commented Mar 5, 2021

@zepumph - I've added a comment to the spot where the checkbox is optionally added, other than that the change looks fine.

One question: Do we know whether this is something that we need to support long term? I'm wondering if we could set up a calendar reminder and delete this in six months or so. I know it's not a lot of code, but it's nice to remove customizations when they're no longer needed just to keep the code clean.

@jbphet jbphet assigned zepumph and unassigned jbphet Mar 5, 2021
@zepumph
Copy link
Member Author

zepumph commented Mar 5, 2021

That's a really good thought and idea. I know we have hacked a bunch in the past in balancing-act, arithmetic, and others. There seems to be no easy way to revert that or to know when this isn't needed anymore. I feel the same way about our custom wrappers like phet-io-wrapper-hookes-law. Marking for phet-io meeting.

@zepumph zepumph removed their assignment Mar 5, 2021
@samreid
Copy link
Member

samreid commented Sep 30, 2021

This relates to the more general issue https://github.com/phetsims/phet-io/issues/1756. If the research scientist could have used studio, he could have made that customization from studio. We decided to leave the query parameter until we have a replacement plan. On hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants