Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decay equation implementation #80

Closed
ariel-phet opened this issue May 16, 2023 · 15 comments
Closed

Decay equation implementation #80

ariel-phet opened this issue May 16, 2023 · 15 comments
Assignees
@Luisav1
Labels
priority:2-high status:ready-for-review

Comments

@ariel-phet
Copy link
Contributor

Try some different mockups with the equation above the zoomed in chart.
@ariel-phet ariel-phet self-assigned this May 16, 2023
@ariel-phet
Copy link
Contributor Author

ariel-phet commented May 23, 2023 •
edited
Loading

zoomed chart 1 zoomed chart 2 zoomed chart 3

@Luisav1
Copy link
Contributor

Luisav1 commented Jul 5, 2023

Will go with the first version for now.

@Luisav1
Copy link
Contributor

Luisav1 commented Jul 5, 2023 •
edited
Loading

Design meeting 7/5:

  • What if there's no cell node, what's the DecayEquationNode representation?
    Leave the equation space, but make it blank.
    Keep the "Most likely decay" but hide the parenthetical percentage
  • What if the nuclide is stable? Should anything show?
    Swap out the equation for the word "Stable"
    Keep the "Most likely decay" but hide the parenthetical percentage
  • What if the decay percentage is null ("unknown")?
    we like a space after the unknown word
  • Unknown decay cases?
    two possibilities: 1. use the word "Unknown" like for "Stable" case. 2 Use "Unknown" only on the right ride of the equation.
    Will go with case 2 for now
  • mostLikelyDecay string font size should match legend

Design meeting 7/13:

  • Make the arrow and the plus sign black instead of blue.
  • Left align the decay equation with the left side of the zoomed in chart grid.

Design meeting 7/20:

  • Center align the decay equation on the zoomed in chart only when 'stable' is shown

zepumph added a commit to phetsims/shred that referenced this issue Jul 5, 2023
@zepumph
First implementation of the DecayEquationNode, phetsims/build-a-nucle…
653e30a 
…us#80
zepumph added a commit that referenced this issue Jul 5, 2023
@zepumph
First implementation of the DecayEquationNode, #80
a28b896
@zepumph
Copy link
Member

zepumph commented Jul 5, 2023

First implementation of the decay equation for the zoomed in chart is above. Here is a screenshot of the NOT pixel polished prototype:

image

This was referenced Jul 6, 2023
Closed
Closed
zepumph added a commit that referenced this issue Jul 7, 2023
@zepumph
add the space, #80
33484b6
@zepumph
Copy link
Member

zepumph commented Jul 7, 2023 •
edited by Luisav1
Loading

From a design meeting today:

  • Let's use a different class from SymbolNode so that the numbers are bigger and closer together.
  • Decay button should be bigger.

@zepumph zepumph changed the title Decay equation layout for partial nuclide chart Decay equation implementation Jul 7, 2023
Luisav1 added a commit that referenced this issue Jul 7, 2023
@Luisav1
DecaySymbolNode.ts is now its own class with a symbol design specific…
5a3ec18 
… to BAN. See #80.
@zepumph
Copy link
Member

zepumph commented Jul 7, 2023

@Luisav1 and I worked on some of the items from our discussion with @ariel-phet today, but not everything. @Luisav1 will take the lead from here.

@zepumph zepumph assigned Luisav1 and unassigned ariel-phet Jul 7, 2023
@zepumph zepumph mentioned this issue Jul 7, 2023
Closed
Luisav1 added a commit that referenced this issue Jul 8, 2023
@Luisav1
Add minWidth to Decay button and increase its font size. See #80.
972cd78
Luisav1 added a commit that referenced this issue Jul 10, 2023
@Luisav1
Factor out decay ArrowNode and decay PlusNode. See #80.
50bd9b2
@zepumph zepumph mentioned this issue Jul 10, 2023
Closed
Luisav1 added a commit that referenced this issue Jul 10, 2023
@Luisav1
Factor out mostLikelyDecayHBox and equation. Separate out the mostLik…
6bc708b 
…elyDecay string and percent. See #80.
Luisav1 added a commit that referenced this issue Jul 11, 2023
@Luisav1
Show 'Stable' string when there's no decay. See #80.
d000b5a
Luisav1 added a commit that referenced this issue Jul 11, 2023
@Luisav1
Show 'Unknown' string when decay type unknown. See #80.
c194f47
Luisav1 added a commit that referenced this issue Jul 11, 2023
@Luisav1
Add blank space and assertions. See #80.
e90abcf
Luisav1 added a commit to phetsims/axon that referenced this issue Jul 11, 2023
@Luisav1
Add blank space and assertions. See phetsims/build-a-nucleus#80.
b86349f
Luisav1 added a commit to phetsims/babel that referenced this issue Jul 11, 2023
@Luisav1
Add blank space and assertions. See phetsims/build-a-nucleus#80.
96458e0
@zepumph
Copy link
Member

zepumph commented Jul 13, 2023

Current look, we still have a few more items to go,
image

Luisav1 added a commit that referenced this issue Jul 17, 2023
@Luisav1
Make plusNode black and left align decay equation. See #80.
89d8435
Luisav1 added a commit that referenced this issue Jul 20, 2023
@Luisav1
Color decay arrow black. See #80.
a7c24a1
Luisav1 added a commit that referenced this issue Jul 20, 2023
@Luisav1
Color decay arrow black. See #80.
c9ce895
Luisav1 added a commit that referenced this issue Jul 24, 2023
@Luisav1
Horizontally center 'Stable' text on the 'Most likely decay' text. Re…
9f3396d 
…name all text nodes to end in _Text instead of _String. See #80.
Luisav1 added a commit that referenced this issue Jul 25, 2023
@Luisav1
Add comments. See #80.
7c7cc62
@zepumph
Copy link
Member

zepumph commented Jul 27, 2023 •
edited
Loading

  • From design meeting today. We need to remove the title arrow, and make the equation arrow match the white one used in the chart view.

@zepumph zepumph assigned zepumph and unassigned Luisav1 Jul 27, 2023
@zepumph
Copy link
Member

zepumph commented Jul 27, 2023 •
edited
Loading

  • Center the "Stable" text over the zoomed in chart

@zepumph
Copy link
Member

zepumph commented Jul 27, 2023

The chart arrow is variable length depending on where in the chart the decay will take you, so I tried to pick a length that felt good compared to all possibilities:

image
image

zepumph added a commit that referenced this issue Jul 27, 2023
@zepumph
decay equation arrow to match the chart's decay arrow, #80
44bc29d
zepumph added a commit that referenced this issue Jul 27, 2023
@zepumph
center "stable" text over the zoomed-in chart node, #80
3fa0d34
@zepumph
Copy link
Member

zepumph commented Jul 27, 2023 •
edited by Luisav1
Loading

Ok I think we are good to go here.

  • @Luisav1 will you give me a spot check about how the stable text is being positioned via a parameter now?
  • @ariel-phet how do you feel about the arrow look now?

@zepumph zepumph assigned Luisav1 and unassigned zepumph Jul 27, 2023
Luisav1 added a commit that referenced this issue Jul 27, 2023
@Luisav1
Add documentation. See #80.
4675633
@ariel-phet
Copy link
Contributor Author

@zepumph I think the arrow looks great!

@ariel-phet ariel-phet assigned zepumph and unassigned ariel-phet Jul 30, 2023
@zepumph
Copy link
Member

zepumph commented Jul 31, 2023

Excellent thanks. @Luisav1 feel free to close after spot check.

@zepumph zepumph removed their assignment Jul 31, 2023
@Luisav1
Copy link
Contributor

Luisav1 commented Aug 1, 2023

Thanks @zepumph, it's all looking good to me. Closing.

@Luisav1 Luisav1 closed this as completed Aug 1, 2023
@Luisav1 Luisav1 mentioned this issue Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luisav1 Luisav1

Labels
priority:2-high status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ariel-phet @zepumph @Luisav1