Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decay screen development #8

Closed
Luisav1 opened this issue Feb 8, 2022 · 1 comment
Closed

Decay screen development #8

Luisav1 opened this issue Feb 8, 2022 · 1 comment
Assignees
@Luisav1

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Feb 8, 2022 •
edited
Loading

I will make commits to this issue for the initial implementation of the decay screen.
@Luisav1 Luisav1 self-assigned this Feb 8, 2022
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Add initial files for decay screen structure. See #8.
39a35c1
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Convert build-a-nucleus-main.ts to typescript. See #8.
93ef641
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Rename DecayScreen.js -> DecayScreen.ts. See #8.
22da55b
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Convert BuildANucleusColors.ts to typescript. See #8.
48a4aee
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Convert BuildANucleusConstants.ts to typescript. See #8.
db07dfa
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Convert DecayScreen.ts contents to typescript. See #8.
e5bf4fd
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Rename DecayModel.js -> DecayModel.ts. See #8.
a8ac2aa
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Rename DecayScreenView.js -> DecayScreenView.ts. See #8.
43ac21a
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Convert DecayModel.ts and DecayScreenView.ts contents to typescript. …
a3e7bdf 
…Use optionize instead of merge for options. See #8.
Luisav1 added a commit that referenced this issue Feb 8, 2022
@Luisav1
Remove unnecessary tandem since tandem is created in the option types…
abb313a 
…. See #8.
Luisav1 added a commit that referenced this issue Feb 9, 2022
@Luisav1
Create the base classes BuildANucleusModel.ts and BuildANucleusScreen…
a993537 
…View.ts which the Decay and Chart screen will extend. BuildANucleusModel.ts has the proton and neutron NumberProperty's. See #8.
Luisav1 added a commit that referenced this issue Feb 9, 2022
@Luisav1
Add two sets of up and down arrow buttons for the protons and neutron…
e12039f 
…s. See #8.
Luisav1 added a commit that referenced this issue Feb 9, 2022
@Luisav1
Create and add NucleonCountPanel.ts. See #8.
a226e02
Luisav1 added a commit that referenced this issue Feb 10, 2022
@Luisav1
Create function to create proton and neutron arrow buttons. See #8.
31a2f81
Luisav1 added a commit that referenced this issue Feb 10, 2022
@Luisav1
Use strings directly instead of in a constant. See #8.
5f1d342
Luisav1 added a commit that referenced this issue Feb 10, 2022
@Luisav1
Right-align the proton and neutron count number readouts. See #8.
47a32ca
Luisav1 added a commit that referenced this issue Feb 10, 2022
@Luisav1
Increase the size of the contents in the NucleonCountPanel.ts. See #8.
fa0e7ef
Luisav1 added a commit that referenced this issue Feb 10, 2022
@Luisav1
Add a function to create the proton and neutron label's on the Nucleo…
beb83f0 
…nCountPanel.ts. See #8.
Luisav1 added a commit that referenced this issue Feb 10, 2022
@Luisav1
Refactor the layout of the nucleon labels, place some of the layout i…
de37bf2 
…nto the function that creates the label's. See #8.
Luisav1 added a commit that referenced this issue Feb 12, 2022
@Luisav1
Create the HalfLifeNumberLineNode.ts which contains the number line a…
285d595 
…nd the arrow. See #8.
Luisav1 added a commit that referenced this issue Feb 12, 2022
@Luisav1
Add a function to add label arrows to the number line, and a function…
4aaec14 
… to convert the half life number in a log scale into a linear scale number. See #8.
Luisav1 added a commit that referenced this issue Feb 12, 2022
@Luisav1
Create and add the HalfLifeInformationNode.ts at the top half of the …
0e0a765 
…decay screen. Add halfLifeNumberProperty and link the half-life arrow and label position to it. See #8.
Luisav1 added a commit that referenced this issue Feb 12, 2022
@Luisav1
Create and add the HalfLifeInfoDialog.ts without the half-life number…
bc7d382 
… line. The half-life number readout can handle a half-life of zero seconds. See #8.
Luisav1 added a commit that referenced this issue Feb 13, 2022
@Luisav1
Add the HalfLifeNumberLineNode to the HalfLifeInfoDialog.ts. See #8.
3fa39bd
Luisav1 added a commit that referenced this issue Feb 13, 2022
@Luisav1
Remove duplicate code when creating the 'more stable' and 'less stabl…
830dbc3 
…e' label and arrow sets. See #8.
Luisav1 added a commit that referenced this issue Feb 13, 2022
@Luisav1
Abbreviate file names from 'BuildANucleus...' -> 'BAN...'. See #8.
aabc4a2
Luisav1 added a commit that referenced this issue Feb 15, 2022
@Luisav1
Naming improvements and half-life can be initialized to zero. See #8.
48ef907
Luisav1 added a commit that referenced this issue Feb 15, 2022
@Luisav1
Create an enum file BANTimescalePoints.ts for the constants in the ha…
edf13b3 
…lf-life info dialog. See #8.
Luisav1 added a commit that referenced this issue Feb 15, 2022
@Luisav1
Add options to HalfLifeNumberLineNode.ts to increase its label sizes …
d97bc56 
…and the number line tick marks. See #8.
Luisav1 added a commit that referenced this issue May 23, 2022
@Luisav1
Beta decay icons show motion lines to the left of the electron/positr…
3d84765 
…on on a new line. The decay buttons have a shorter width. See #8.
Luisav1 added a commit to phetsims/shred that referenced this issue May 24, 2022
@Luisav1
Slowly change the color when a nucleon type changes. See phetsims/bui…
84a635e 
…ld-a-nucleus#8.
Luisav1 added a commit that referenced this issue May 25, 2022
@Luisav1
Shorten arrows in HalfLifeInfoDialog and center HalfLifeInfoDialog's …
aa1ffb5 
…contents. See #8.
Luisav1 added a commit to phetsims/shred that referenced this issue May 25, 2022
@Luisav1
Slowly change the color of the ParticleNode.js when the nucleon type …
0eb0d54 
…changes. See phetsims/build-a-nucleus#8.
Luisav1 added a commit that referenced this issue May 30, 2022
@Luisav1
Shorten beta decay particle motion lines and place it all in one line…
ec9efbf 
…. See #8.
Luisav1 added a commit that referenced this issue May 30, 2022
@Luisav1
Reduce cornerRadius rounding on all panels and increase symbol accord…
9836cea 
…ion box width and height. See #8.
Luisav1 added a commit that referenced this issue May 30, 2022
@Luisav1
Increase half-life arrow length in HalfLifeInfoDialog.ts. Move halfLi…
b7244fd 
…feText closer to the elementName, and farther from the halfLifeArrow, in HalfLifeInfoDialog.ts. See #8.
Luisav1 added a commit that referenced this issue May 30, 2022
@Luisav1
Wait 0.3 seconds after the nucleon starts changing color to emit the …
7c79e3d 
…particle in a beta decay. See #8.
Luisav1 added a commit to phetsims/shred that referenced this issue May 30, 2022
@Luisav1
Wait 0.3 seconds after the nucleon starts changing color to emit the …
2e760e6 
…particle in a beta decay. See phetsims/build-a-nucleus#8.
Luisav1 added a commit that referenced this issue May 31, 2022
@Luisav1
Emit the 2 remaining protons after 1 second when an alpha decay is do…
bb164b8 
…ne on Beryllium-6. See #8.
Luisav1 added a commit that referenced this issue May 31, 2022
@Luisav1
Remove TODO's no longer applicable. Decrease panels' corner radius. I…
3db48e7 
…ncrease the symbol expandCollapse button size and decrease the margin's around it. See #8.
Luisav1 added a commit that referenced this issue May 31, 2022
@Luisav1
Emit the 2 remaining protons, after Beryllium-6 alpha decay's, when t…
538823b 
…he alpha particle is a certain distance away from the nucleus. See #8.
Luisav1 added a commit to phetsims/shred that referenced this issue Jun 3, 2022
@Luisav1
Animate the changing color of the nucleus from a beta decay in the Pa…
9c903dd 
…rticleAtom.js. Emit the electron or positon from a beta decay once the color change animation is halfway through. See phetsims/build-a-nucleus#8.
Luisav1 added a commit that referenced this issue Jun 3, 2022
@Luisav1
Animate the changing color of the nucleus from a beta decay in the Pa…
aa2553f 
…rticleAtom.js. Emit the electron or positon from a beta decay once the color change animation is halfway through. See #8.
Luisav1 added a commit to phetsims/shred that referenced this issue Jun 4, 2022
@Luisav1
Fix stable element table data. See phetsims/build-a-nucleus#8.
a6740d3
Luisav1 added a commit to phetsims/shred that referenced this issue Jun 10, 2022
@Luisav1
Merge in some commits from the build-a-nucleus branch: fix half-life …
2d75c68 
…stable isotopes data, the symbol node has a dash '-' when the protonCount is zero, show the type of the unexpected particle type in an assertion. See phetsims/build-a-nucleus#8.
Luisav1 added a commit that referenced this issue Jun 15, 2022
@Luisav1
Add the decay that caused the error to the assertion message in emitN…
98108e6 
…ucleon. See #8.
Luisav1 added a commit that referenced this issue Jun 17, 2022
@Luisav1
Comment out call to changeNucleonType. See #8.
c146bf2
Luisav1 added a commit that referenced this issue Jun 20, 2022
@Luisav1
Comment in call to changeNucleonType. See #8.
14457a2
Luisav1 added a commit that referenced this issue Jul 6, 2022
@Luisav1
Reconfigure the nucleus when a nucleon is removed from the particleAt…
a0bcc54 
…om. See #8.
Luisav1 added a commit that referenced this issue Jul 20, 2022
@Luisav1
Use DecayType enumeration in assertion error message. See #8.
617e735
Luisav1 added a commit that referenced this issue Jul 20, 2022
@Luisav1
Update version. See #8.
28c4d0a
Luisav1 added a commit that referenced this issue Aug 2, 2022
@Luisav1
Use the name enumeration of a value instead of its string translatabl…
0124118 
…e value. See #8.
Luisav1 added a commit that referenced this issue Aug 31, 2022
@Luisav1
Rename function returnNucleonCountAtRange -> isNucleonCountAtRangeBou…
d0083c4 
…nds. See #8.
Luisav1 added a commit that referenced this issue Aug 31, 2022
@Luisav1
Rename function removeParticleAndCheckCreatorNodeVisibility -> remove…
5d393d8 
…ParticleAndSetCreatorNodeVisibility. See #8.
Luisav1 added a commit that referenced this issue Oct 19, 2022
@Luisav1
Rename function returnNucleonCountAtRange -> isNucleonCountAtRangeBou…
cda74e2 
…nds. See #8.
Luisav1 added a commit that referenced this issue Oct 19, 2022
@Luisav1
Rename function removeParticleAndCheckCreatorNodeVisibility -> remove…
c115056 
…ParticleAndSetCreatorNodeVisibility. See #8.
@zepumph
Copy link
Member

zepumph commented Jul 6, 2023

This issue can be closed. Thanks everyone!

@zepumph zepumph closed this as completed Jul 6, 2023
@pixelzoom pixelzoom mentioned this issue Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luisav1 Luisav1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @Luisav1