Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlap seen with stringTests #27

Closed
Nancy-Salpepi opened this issue Jun 8, 2022 · 4 comments
Closed

Overlap seen with stringTests #27

Nancy-Salpepi opened this issue Jun 8, 2022 · 4 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
macOS 12.4

Browser
safari

Problem description
For phetsims/qa#809 I see overlap of text and text/panels when using stringTest=double, long and RTL.

Visuals
Screen Shot 2022-06-08 at 12 34 56 PM

Screen Shot 2022-06-08 at 12 35 29 PM

Screen Shot 2022-06-08 at 12 36 46 PM

Screen Shot 2022-06-08 at 12 38 22 PM

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Build a Nucleus‬ URL: https://phet-dev.colorado.edu/html/build-a-nucleus/1.0.0-betaDecay.11/phet/build-a-nucleus_all_phet.html Version: 1.0.0-betaDecay.11 2022-06-04 01:06:50 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.61 Safari/537.36 Language: en-US Window: 1365x694 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
Luisav1 added a commit that referenced this issue Jun 15, 2022
Luisav1 added a commit that referenced this issue Jun 17, 2022
…s determined by the position of the particle node's in those labels. See #27.
Luisav1 added a commit that referenced this issue Jun 17, 2022
…er line. Position the stability labels beside the arrows based on their respective arrow positions. See #27.
Luisav1 added a commit that referenced this issue Jun 19, 2022
…d set a height for the AvailableDecaysPanel.ts. See #27.
Luisav1 added a commit that referenced this issue Jun 19, 2022
…ailableDecaysPanel.ts based off of the symbolAccordionBox. Align the bottom of the electronCloudCheckbox with the bottom of the reset button. Use the height of the halfLifeDisplayNode to place the elementName in the HalfLifeNumberLineNode.ts. See #27.
@Luisav1
Copy link
Contributor

Luisav1 commented Jun 21, 2022

Thanks @Nancy-Salpepi! This should be fixed in the commits above. You can check it and close it if it's fixed.

@Nancy-Salpepi
Copy link
Author

Hi @Luisav1! Things are looking much better, but I'm still seeing overlap in the particle count panel with stringTest=double and stringTest=long.
Screen Shot 2022-06-21 at 1 14 26 PM
Screen Shot 2022-06-21 at 1 15 24 PM

@Luisav1
Copy link
Contributor

Luisav1 commented Jun 21, 2022

I missed that, thanks @Nancy-Salpepi! It should be fixed now.

@Nancy-Salpepi
Copy link
Author

Looks good @Luisav1! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants