You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The name of the ParticleNucleus class in, IMO, misleading and it cost me some time when trying to understand some portions of the code. The term "nucleus" is defined (in the Webster dictionary) as "a central point, group, or mass about which gathering, concentration, or accretion takes place." However, ParticleNucleus is actually a spread out collection of nucleons based on their energy levels. I realize that it's hard to get completely away from the term "nucleus" since that's the only place where nucleons tend to hang out together, so how about something like "LayeredNucleus", "SchematicNucleus", or "ExpandedNucleus"? Feel free to insert "Particle" if you feel it's necessary, i.e. "LayeredParticleNucleus".
The text was updated successfully, but these errors were encountered:
Related to #165.
The name of the
ParticleNucleus
class in, IMO, misleading and it cost me some time when trying to understand some portions of the code. The term "nucleus" is defined (in the Webster dictionary) as "a central point, group, or mass about which gathering, concentration, or accretion takes place." However,ParticleNucleus
is actually a spread out collection of nucleons based on their energy levels. I realize that it's hard to get completely away from the term "nucleus" since that's the only place where nucleons tend to hang out together, so how about something like "LayeredNucleus", "SchematicNucleus", or "ExpandedNucleus"? Feel free to insert "Particle" if you feel it's necessary, i.e. "LayeredParticleNucleus".The text was updated successfully, but these errors were encountered: