Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing name of ParticleNucleus class #183

Closed
jbphet opened this issue Aug 25, 2023 · 2 comments
Closed

Consider changing name of ParticleNucleus class #183

jbphet opened this issue Aug 25, 2023 · 2 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 25, 2023

Related to #165.

The name of the ParticleNucleus class in, IMO, misleading and it cost me some time when trying to understand some portions of the code. The term "nucleus" is defined (in the Webster dictionary) as "a central point, group, or mass about which gathering, concentration, or accretion takes place." However, ParticleNucleus is actually a spread out collection of nucleons based on their energy levels. I realize that it's hard to get completely away from the term "nucleus" since that's the only place where nucleons tend to hang out together, so how about something like "LayeredNucleus", "SchematicNucleus", or "ExpandedNucleus"? Feel free to insert "Particle" if you feel it's necessary, i.e. "LayeredParticleNucleus".

@zepumph
Copy link
Member

zepumph commented Aug 28, 2023

Thanks @jbphet. We are in agreement! We would like to rename this to

ShellModelNucleus. And in the view we have a NucleonShellView for each particle type, and that flows pretty well together.

@zepumph
Copy link
Member

zepumph commented Aug 30, 2023

Working on this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants