Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT Unexpected particle type. #18

Closed
KatieWoe opened this issue Jun 6, 2022 · 3 comments
Closed

CT Unexpected particle type. #18

KatieWoe opened this issue Jun 6, 2022 · 3 comments
Assignees
@chrisklus @Luisav1
Labels
priority:4-low type:automated-testing

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Jun 6, 2022 

build-a-nucleus : multitouch-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22multitouch-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654319562134%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Uncaught Error: Unexpected particle type.
Error: Unexpected particle type.
at (ParticleAtom.js:369:12)
at addParticle (DecayScreenView.ts:553:11)
at dragEndedListener (BANScreenView.ts:336:66)
at listener (TinyEmitter.ts:94:8)
at emit (Emitter.ts:66:21)
at emit (ParticleView.js:81:36)
at _end (DragListener.ts:393:24)
at callback (PressListener.ts:751:16)
at apply (PhetioAction.ts:124:16)
at execute (PressListener.ts:509:24)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : multitouch-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22multitouch-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654396870986%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Uncaught Error: Unexpected particle type.
Error: Unexpected particle type.
at (ParticleAtom.js:369:12)
at addParticle (DecayScreenView.ts:553:11)
at dragEndedListener (BANScreenView.ts:336:66)
at listener (TinyEmitter.ts:94:8)
at emit (Emitter.ts:66:21)
at emit (ParticleView.js:81:36)
at _end (DragListener.ts:393:24)
at callback (PressListener.ts:751:16)
at apply (PhetioAction.ts:124:16)
at execute (PressListener.ts:509:24)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : multitouch-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22multitouch-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654503450819%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Uncaught Error: Unexpected particle type.
Error: Unexpected particle type.
at (ParticleAtom.js:369:12)
at addParticle (DecayScreenView.ts:553:11)
at dragEndedListener (BANScreenView.ts:336:66)
at listener (TinyEmitter.ts:94:8)
at emit (Emitter.ts:66:21)
at emit (ParticleView.js:81:36)
at _end (DragListener.ts:393:24)
at callback (PressListener.ts:751:16)
at apply (PhetioAction.ts:124:16)
at execute (PressListener.ts:509:24)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : pan-and-zoom-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22pan-and-zoom-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654306744466%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Uncaught Error: Unexpected particle type.
Error: Unexpected particle type.
at (ParticleAtom.js:369:12)
at addParticle (DecayScreenView.ts:553:11)
at dragEndedListener (BANScreenView.ts:336:66)
at listener (TinyEmitter.ts:94:8)
at emit (Emitter.ts:66:21)
at emit (ParticleView.js:81:36)
at _end (DragListener.ts:393:24)
at callback (PressListener.ts:751:16)
at apply (PhetioAction.ts:124:16)
at execute (PressListener.ts:509:24)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : pan-and-zoom-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22pan-and-zoom-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654354525505%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Uncaught Error: Unexpected particle type.
Error: Unexpected particle type.
at (ParticleAtom.js:369:12)
at addParticle (DecayScreenView.ts:553:11)
at dragEndedListener (BANScreenView.ts:336:66)
at listener (TinyEmitter.ts:94:8)
at emit (Emitter.ts:66:21)
at emit (ParticleView.js:81:36)
at _end (DragListener.ts:393:24)
at callback (PressListener.ts:751:16)
at apply (PhetioAction.ts:124:16)
at execute (PressListener.ts:509:24)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : pan-and-zoom-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22pan-and-zoom-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654368467435%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Uncaught Error: Assertion failed: The particleAtom needs a PROTON to emit it.
Error: Assertion failed: The particleAtom needs a PROTON to emit it.
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/assert/js/assert.js:28:13)
at assert (DecayScreenView.ts:385:14)
at emitNucleon (DecayScreenView.ts:476:35)
at baseTimes (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/sherpa/lib/lodash-4.17.4.js:997:23)
at Function.times (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/sherpa/lib/lodash-4.17.4.js:16095:20)
at times (DecayScreenView.ts:476:12)
at listener (TinyEmitter.ts:94:8)
at emit (AbstractProperty.ts:255:22)
at _notifyListeners (AbstractProperty.ts:206:13)
at set (Property.ts:67:10)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : pan-and-zoom-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22pan-and-zoom-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654387187703%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Uncaught Error: Unexpected particle type.
Error: Unexpected particle type.
at (ParticleAtom.js:369:12)
at addParticle (DecayScreenView.ts:553:11)
at dragEndedListener (BANScreenView.ts:336:66)
at listener (TinyEmitter.ts:94:8)
at emit (Emitter.ts:66:21)
at emit (ParticleView.js:81:36)
at _end (DragListener.ts:393:24)
at callback (PressListener.ts:751:16)
at apply (PhetioAction.ts:124:16)
at execute (PressListener.ts:509:24)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : pan-and-zoom-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22pan-and-zoom-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654456657039%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Uncaught Error: Unexpected particle type.
Error: Unexpected particle type.
at (ParticleAtom.js:369:12)
at addParticle (DecayScreenView.ts:553:11)
at dragEndedListener (BANScreenView.ts:336:66)
at listener (TinyEmitter.ts:94:8)
at emit (Emitter.ts:66:21)
at emit (ParticleView.js:81:36)
at _end (DragListener.ts:393:24)
at callback (PressListener.ts:751:16)
at apply (PhetioAction.ts:124:16)
at execute (PressListener.ts:509:24)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : pan-and-zoom-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22pan-and-zoom-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654517137681%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Uncaught Error: Assertion failed: reentry detected, value=Vector2(271.96742271791874, -164.21635418000506), oldValue=Vector2(270.1697154856001, -163.1308825282014)
Error: Assertion failed: reentry detected, value=Vector2(271.96742271791874, -164.21635418000506), oldValue=Vector2(270.1697154856001, -163.1308825282014)
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/assert/js/assert.js:28:13)
at assert (AbstractProperty.ts:252:14)
at _notifyListeners (AbstractProperty.ts:206:13)
at set (Property.ts:67:10)
at set (Property.ts:53:9)
at (AnimationTarget.js:296:6)
at setValue (AnimationTarget.js:331:9)
at update (Animation.js:308:24)
at listener (TinyEmitter.ts:94:8)
at emit (Sim.ts:447:16)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM

----------------------------------

build-a-nucleus : pan-and-zoom-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/build-a-nucleus/build-a-nucleus_en.html?continuousTest=%7B%22test%22%3A%5B%22build-a-nucleus%22%2C%22pan-and-zoom-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1654295157038%22%2C%22timestamp%22%3A1654530178779%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=true
Uncaught Error: Assertion failed: The particleAtom needs a PROTON to emit it.
Error: Assertion failed: The particleAtom needs a PROTON to emit it.
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/assert/js/assert.js:28:13)
at assert (DecayScreenView.ts:385:14)
at emitNucleon (DecayScreenView.ts:476:35)
at baseTimes (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/sherpa/lib/lodash-4.17.4.js:997:23)
at Function.times (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1654295157038/sherpa/lib/lodash-4.17.4.js:16095:20)
at times (DecayScreenView.ts:476:12)
at listener (TinyEmitter.ts:94:8)
at emit (AbstractProperty.ts:255:22)
at _notifyListeners (AbstractProperty.ts:206:13)
at set (Property.ts:67:10)
id: Bayes Puppeteer
Snapshot from 6/3/2022, 4:25:57 PM
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Jun 7, 2022

This was found in phetsims/qa#809 while doing a fuzz test on the debug version of the sim:
indebug

@Nancy-Salpepi Nancy-Salpepi mentioned this issue Jun 8, 2022
Closed
Luisav1 added a commit to phetsims/shred that referenced this issue Jun 9, 2022
@Luisav1
Changed an error to an assertion that prints out the type of unexpect…
dabef4e 
…ed particle. See phetsims/build-a-nucleus#18.
Luisav1 added a commit that referenced this issue Jun 9, 2022
@Luisav1
Stop any animations on the if the particle is removed. Dispose the li…
77ec44d 
…steners on the animationEndedEmitter for a particle before the particle is disposed. See #18.
Luisav1 added a commit to phetsims/shred that referenced this issue Jun 9, 2022
@Luisav1
Stop any animations on the if the particle is removed. Dispose the li…
eff9a54 
…steners on the animationEndedEmitter for a particle before the particle is disposed. See phetsims/build-a-nucleus#18.
@Luisav1
Copy link
Contributor

Luisav1 commented Jun 9, 2022

Thanks @KatieWoe and @Nancy-Salpepi! @chrisklus and I hopefully fixed this in the commits above but we'll monitor CT to see if it comes up again.

Luisav1 added a commit that referenced this issue Jun 10, 2022
@Luisav1
Only add the particleDragFinished listener if the particle is a proto…
ac22dd4 
…n or a neutron. See #18.
@Luisav1
Copy link
Contributor

Luisav1 commented Jun 20, 2022

We didn't see this issue come up in CT again so it seems fixed. Closing.

@Luisav1 Luisav1 closed this as completed Jun 20, 2022
@marlitas marlitas mentioned this issue Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisklus chrisklus

@Luisav1 Luisav1

Labels
priority:4-low type:automated-testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisklus @KatieWoe @Luisav1