Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically changing locales causes inconsistent radio button sizes #178

Closed
jbphet opened this issue Aug 24, 2023 · 4 comments
Closed

Dynamically changing locales causes inconsistent radio button sizes #178

jbphet opened this issue Aug 24, 2023 · 4 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 24, 2023

Found during code review, see #165.

When the locale is changed dynamically it can cause the radio button sizes to be inconsistent. There are a couple of screenshots below to illustrate. This is a know common code issue, see phetsims/sun#852, but I thought I should log it so that the designer can decide how important it is to get this fixed before publication.

To illustrate, here is an example of the "Available Decays" panel when launched with locale=de (German):

image

Here's what this panel looks like if launched with locales=* and then the locale is changed to Deutsch (German):

image

@jbphet
Copy link
Contributor Author

jbphet commented Aug 24, 2023

Here are a couple of other examples that look a bit worse.

Kurdish:

image

French:

image

@jbphet jbphet changed the title Changing locales causes inconsistent radio button sizes Dynamically changing locales causes inconsistent radio button sizes Aug 24, 2023
@jbphet
Copy link
Contributor Author

jbphet commented Aug 24, 2023

Assigning to the people that I think did the design to prioritize this. They can pass it on as appropriate.

@zepumph
Copy link
Member

zepumph commented Aug 28, 2023

@Luisav1 and I would like to pair on this so she can get a glimpse at some of the i18n dynamic locale work.

@Luisav1
Copy link
Contributor

Luisav1 commented Aug 29, 2023

@zepumph and I fixed this in the commit above. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants