-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions for improving the documentation style #173
Labels
Comments
Thank @jbphet, that's a great suggestion. This was addressed in the commits above. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #165. I received some feedback in a code review a while back about inconsistent use of sentence fragments, punctuation, etc. See phetsims/number-line-operations#54. I'm seeing the same issue in the comments for this sim. Here is a short example. Note that the first comment is a fragment, which is fine, the second is a full sentence with capitalization, also fine. The third is a complete sentence written as a fragment.
The inconsistencies in the style requires more cognitive effort for readers to interpret.
I made the changes that were suggested in phetsims/number-line-operations#54 and it took less time then I thought it would, and I feel that it improved the code. I know PhET has no standard for this, but I thought I'd put it out there for consideration.
The text was updated successfully, but these errors were encountered: