-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding labels to the full nucleus stability chart #168
Comments
I like the idea! Let's see what @Luisav1 thinks. |
In addition to this work, @Luisav1 was talking to Jason and they may be changing the colors in the full chart app anyways. Let's wait for that to happen before taking a new screenshot. Don't forget to update the notes of the license over in #180 with what it takes to get the new screenshot (more details is better!). |
@Luisav1, what is the current status of this issue? |
The screenshot now shows the full nuclide chart with matching colors to the sim and axis labels as well. Closing. |
There is a button in the "Chart Intro" screen that brings up a modal dialog containing a full chart of nucleus stabilities. There are no labels on the axes of this chart, which I recall being a pet peeve of one of my former teachers. When I click on the "Full Chart" link in this dialog, a web page is opened that shows an interactive version of the chart with labels on the axes. However, PhET sims are sometimes used in environments where outside internet access isn't available, so students might not be able to access the click-thru version of the chart. Thus, I think it would be good to have labels on the chart that is available within the sim.
Full chart from sim:
Full chart from external link available in the sim:
This came up during code review, see #165.
The text was updated successfully, but these errors were encountered: