Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding labels to the full nucleus stability chart #168

Closed
jbphet opened this issue Aug 23, 2023 · 5 comments
Closed

Consider adding labels to the full nucleus stability chart #168

jbphet opened this issue Aug 23, 2023 · 5 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 23, 2023

There is a button in the "Chart Intro" screen that brings up a modal dialog containing a full chart of nucleus stabilities. There are no labels on the axes of this chart, which I recall being a pet peeve of one of my former teachers. When I click on the "Full Chart" link in this dialog, a web page is opened that shows an interactive version of the chart with labels on the axes. However, PhET sims are sometimes used in environments where outside internet access isn't available, so students might not be able to access the click-thru version of the chart. Thus, I think it would be good to have labels on the chart that is available within the sim.

Full chart from sim:

image

Full chart from external link available in the sim:

image

This came up during code review, see #165.

@zepumph
Copy link
Member

zepumph commented Aug 25, 2023

I like the idea! Let's see what @Luisav1 thinks.

@zepumph zepumph removed their assignment Aug 25, 2023
@zepumph
Copy link
Member

zepumph commented Aug 28, 2023

In addition to this work, @Luisav1 was talking to Jason and they may be changing the colors in the full chart app anyways. Let's wait for that to happen before taking a new screenshot. Don't forget to update the notes of the license over in #180 with what it takes to get the new screenshot (more details is better!).

@zepumph
Copy link
Member

zepumph commented Sep 14, 2023

@Luisav1, what is the current status of this issue?

@Luisav1
Copy link
Contributor

Luisav1 commented Sep 15, 2023

The screenshot still has a little black stroke on the right that needs to be removed.
image
Update the screenshot and then close.

@Luisav1
Copy link
Contributor

Luisav1 commented Sep 18, 2023

The screenshot now shows the full nuclide chart with matching colors to the sim and axis labels as well. Closing.

@Luisav1 Luisav1 closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants