Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset All isn't resetting several things in the 2nd screen #167

Closed
jbphet opened this issue Aug 23, 2023 · 1 comment
Closed

Reset All isn't resetting several things in the 2nd screen #167

jbphet opened this issue Aug 23, 2023 · 1 comment
Assignees
@zepumph @Luisav1
Labels
dev:code-review

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 23, 2023

Pressing the "Reset All" button in the 2nd screen does not reset the state of the chart zoom-in radio buttons, the "Magic Numbers" checkbox, or the expansion state of the accordion box.

I tested the checkbox and accordion box on the first screen, and these seem to reset just fine.
@jbphet
Copy link
Contributor Author

jbphet commented Aug 23, 2023

Found during code review, see #165.

@zepumph zepumph closed this as completed Aug 25, 2023
zepumph added a commit that referenced this issue Aug 25, 2023
@zepumph
reset a couple more things on the second screen, #167
242dd71
zepumph added a commit to phetsims/shred that referenced this issue Aug 25, 2023
@zepumph
reset a couple more things on the second screen, phetsims/build-a-nuc…
4b447fb 
…leus#167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

@Luisav1 Luisav1

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbphet @zepumph @Luisav1