Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename *BooleanProperty -> *Property #166

Closed
zepumph opened this issue Aug 23, 2023 · 1 comment
Closed

Rename *BooleanProperty -> *Property #166

zepumph opened this issue Aug 23, 2023 · 1 comment
Assignees
@zepumph
Labels
dev:code-review

Comments

@zepumph
Copy link
Member

zepumph commented Aug 23, 2023

Like for doesNuclideExistBooleanProperty, it is redundant to call it a Boolean Property. The name should signify that with "does"

nuclideExistsProperty could also be a simpler name.

Tagging @jbphet since he is currently working on the code review. We hit this while cleaning up over in #164
@zepumph zepumph self-assigned this Aug 23, 2023
@zepumph
Copy link
Member Author

zepumph commented Aug 25, 2023

I renamed:

isStableBooleanProperty
showMagicNumbersBooleanProperty
arrowXPositionNumberProperty
doesNuclideExistBooleanProperty
halfLifeArrowRotationNumberProperty

Closing

@zepumph zepumph closed this as completed Aug 25, 2023
zepumph added a commit that referenced this issue Aug 25, 2023
@zepumph
rename *BooleanProperty *NumberProperty to *Property, #166
c4f58a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph