handle review comments, #165

phetsims · Aug 28, 2023 · a180546 · a180546
1 parent 6354bb2
commit a180546
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/js/common/model/BANModel.ts b/js/common/model/BANModel.ts
@@ -108,7 +108,7 @@ class BANModel<T extends ParticleAtom> {
 
     this.particles.addItemAddedListener( particle => {
 
-      // REVIEW: Should there be an unlink for when the particles are removed?  If unnecessary, document why.
+      // No need to remove because when a particle is removed from this.particles, it is disposed
       particle.userControlledProperty.link( isUserControlled => userControlledListener( isUserControlled, particle ) );
     } );
 

diff --git a/js/decay/model/DecayModel.ts b/js/decay/model/DecayModel.ts
@@ -20,7 +20,8 @@ class DecayModel extends BANModel<ParticleAtom> {
   // the half-life number
   public halfLifeNumberProperty: TReadOnlyProperty<number>;
 
-  // REVIEW: Some docs about this field would be helpful.
+  // A data structure for all the enabledProperties for the "decay buttons". These enabledProperties toggle to enabled
+  // when the Nuclide supports that given decay type.
   public decayEnabledPropertyMap: Map<DecayType, TReadOnlyProperty<boolean>>;
 
   public constructor() {