minor refactors, #182

phetsims · Aug 28, 2023 · a068850 · a068850
1 parent 70d870e
commit a068850
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/js/common/view/BANScreenView.ts b/js/common/view/BANScreenView.ts
@@ -192,7 +192,7 @@ abstract class BANScreenView<M extends BANModel<ParticleAtom | ParticleNucleus>>
       if ( particleType === ParticleType.PROTON || particleType === ParticleType.NEUTRON ) {
 
         // called when a nucleon is finished being dragged
-        particle.dragEndedEmitter.addListener( () => { this.dragEndedListener( particle, this.model.particleAtom ); } );
+        particle.dragEndedEmitter.addListener( () => this.dragEndedListener( particle, this.model.particleAtom ) );
         this.checkIfCreatorNodeShouldBeInvisible( particleType );
       }
 

diff --git a/js/common/view/NucleonArrowButtons.ts b/js/common/view/NucleonArrowButtons.ts
@@ -65,11 +65,11 @@ class NucleonArrowButtons extends Node {
         const neutronNumber = atomNeutronNumber + incomingNeutronsNumber + userControlledNeutronNumber;
         const userControlledNucleonNumber = userControlledNeutronNumber + userControlledProtonNumber;
         const doesNuclideExist = AtomIdentifier.doesExist( protonNumber, neutronNumber );
+        const massNumber = atomProtonNumber + atomNeutronNumber;
 
         // Disable all buttons if the nuclide doesn't exist and one of the two cases:
         // Something is being user controlled OR Particle Atom is not empty
-        if ( !doesNuclideExist &&
-             ( model.particleAtom.massNumberProperty.value !== 0 || userControlledNucleonNumber !== 0 ) ) {
+        if ( !doesNuclideExist && ( massNumber !== 0 || userControlledNucleonNumber !== 0 ) ) {
 
           // disable all arrow buttons if the nuclide does not exist
           NucleonArrowButtons.toggleCreatorNodeEnabled( protonsCreatorNode, false );