Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to skip levels by re-doing a previous one #194

Closed
KatieWoe opened this issue Jun 9, 2020 · 4 comments
Closed

Able to skip levels by re-doing a previous one #194

KatieWoe opened this issue Jun 9, 2020 · 4 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Jun 9, 2020

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#506.
It is possible to skip a level by going back to a previous one and redoing it. Once the old level is re completed, the "go to the next level" prompt will come up, and it will create a new level past the uncompleted one.
Steps to reproduce

  1. Complete Level one in a game and move to level two
  2. Use the arrow to go back to level one
  3. Use the yellow refresh level to start level one again
  4. Complete level one again and choose to go to the next level.
  5. You are now on level three without having done level two

Visuals
skiplevels

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Build a Molecule‬
URL: https://phet-dev.colorado.edu/html/build-a-molecule/1.0.0-dev.75/phet/build-a-molecule_all_phet.html
Version: 1.0.0-dev.75 2020-06-01 13:20:12 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

Denz1994 added a commit that referenced this issue Jun 10, 2020
…available. Prevents skipping levels by completing a previous level. #194
@Denz1994
Copy link
Contributor

Great catch! The allFilledDialog has been fixed to only show if there isn't a nextCollection present on the currentCollection. This means we should only get the next collection prompt on the last collection (or level).

I'll post a dev version to verify.

@Denz1994
Copy link
Contributor

This dev version can be used for verification.

@KatieWoe
Copy link
Contributor Author

Looks good on that dev version

@Denz1994
Copy link
Contributor

Thanks. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants