-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset All inconsistent collection. First reset won't let you continue #135
Comments
Now that I think of it, it may be related to #121 |
I think this has been fixed in the above commit. It can be verified on the latest dev version. |
Can you confirm this is fixed @KatieWoe? |
This is fixed.
This is not fixed. |
I see. I wasn't resetting the allFilledProperty along with the flag determining if the dialog has shown once on the BAMScreenSubtypes. This change has been made in this dev version. |
Appears to be fully fixed now |
Nice. Closing this one. |
Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
Found when checking #122. Seems unrelated to that issue.
When you reset the first or second screen after completing a collection, the first time it will reset to show the first collection. If you hit reset again it shows you Collection 1, but it will be the collection you were on before, with those atoms and molecules. If you try to complete the collection after the first reset you will not get the continue dialog after completing it.
Steps to reproduce
Visuals
Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: Build a Molecule
URL: https://phet-dev.colorado.edu/html/build-a-molecule/0.0.0-dev.33/phet/build-a-molecule_en_phet.html
Version: 0.0.0-dev.33 2019-12-16 16:05:03 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.79 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}
The text was updated successfully, but these errors were encountered: