Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large memory test and leak #115

Closed
KatieWoe opened this issue Nov 22, 2019 · 9 comments
Closed

Large memory test and leak #115

KatieWoe opened this issue Nov 22, 2019 · 9 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#459
Start: 136 MB
1 min: 224
2 min: 282
3 min: 333
4 min: 381
5 min: 426
6 min: 471
7 min: crash

@loganbraywork
Copy link

For phetsims/qa#479
Start: 156 MB
10 Minute interval: 658 MB
After the snapshot was taken and saved (which took about 20 minutes to finish) the sim crashed without starting up again and began to cause immense slowdowns on my PC.

@Denz1994
Copy link
Contributor

Denz1994 commented Mar 11, 2020

The latest memory test was recorded with 15 min intervals (Chrome Version 80.0.3987.122, macOS Catalina 10.15.1). It looks like there is significant improvements but there are some TODOs left in the code related to optimization, so we may be able to squeeze out a better performance.

Here are my results:
image

@KatieWoe Could you run a similar test to the original post? Have the results improved from your initial test? Try this dev version here.

@Denz1994
Copy link
Contributor

Also assigning @loganbraywork since he reported in this issue as well. Whoever gets to it first, should be fine to test it.

@KatieWoe
Copy link
Contributor Author

Results:
Start: 109 MB
1 min: 145 MB
2 min: 164 MB
3 min: 183 MB
4 min: 196 MB
5 min: 209 MB
6 min: 219 MB
7 min: Memory tab crashed and closed

@Denz1994
Copy link
Contributor

Denz1994 commented Mar 11, 2020

@KatieWoe What device and browser where you using? Removing @loganbraywork's assignment.

@KatieWoe
Copy link
Contributor Author

Windows 10 Chrome Laptop

@Denz1994
Copy link
Contributor

Additional memory leaks have been identified and removed in the above commits. Can @KatieWoe do another memory test similar to #115 (comment)?

@KatieWoe
Copy link
Contributor Author

From Master:
Start: 109 MB
1 min: 118 MB
2 min: 120 MB
3 min: 121 MB
4 min: 121 MB
5 min: 122 MB
6 min: 123 MB
7 min: 125 MB
8 min: 126 MB
9 min: 126 MB
10 min: 127 MB

Looks good

Denz1994 added a commit that referenced this issue Mar 25, 2020
@Denz1994
Copy link
Contributor

Denz1994 commented Apr 8, 2020

The latest memory test is looking good. We can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants