-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large memory test and leak #115
Comments
For phetsims/qa#479 |
…le Vector2.add(), and move numMolecules declaration out of loops. #115
The latest memory test was recorded with 15 min intervals (Chrome Version 80.0.3987.122, macOS Catalina 10.15.1). It looks like there is significant improvements but there are some TODOs left in the code related to optimization, so we may be able to squeeze out a better performance. @KatieWoe Could you run a similar test to the original post? Have the results improved from your initial test? Try this dev version here. |
Also assigning @loganbraywork since he reported in this issue as well. Whoever gets to it first, should be fine to test it. |
Results: |
@KatieWoe What device and browser where you using? Removing @loganbraywork's assignment. |
Windows 10 Chrome Laptop |
Additional memory leaks have been identified and removed in the above commits. Can @KatieWoe do another memory test similar to #115 (comment)? |
From Master: Looks good |
The latest memory test is looking good. We can close this one. |
For phetsims/qa#459
Start: 136 MB
1 min: 224
2 min: 282
3 min: 333
4 min: 381
5 min: 426
6 min: 471
7 min: crash
The text was updated successfully, but these errors were encountered: