MaxWidth adjusted for collection panel texts. Doc update and remove u…

…nused constant. #164
phetsims · Mar 9, 2020 · d70e927 · d70e927
1 parent 022d901
commit d70e927
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/js/common/view/CollectionBoxNode.js b/js/common/view/CollectionBoxNode.js
@@ -21,7 +21,6 @@ import Molecule3DNode from './view3d/Molecule3DNode.js';
 import ShowMolecule3DButtonNode from './view3d/ShowMolecule3DButtonNode.js';
 
 // constants
-const MOLECULE_PADDING = 0;
 const BLACK_BOX_PADDING = BAMConstants.HAS_3D ? 7 : 0;
 
 class CollectionBoxNode extends VBox {
@@ -35,7 +34,7 @@ class CollectionBoxNode extends VBox {
     super( options );
     this.box = box;
     this.moleculeNodes = [];
-    this.moleculeNodeMap = {}; // molecule ID => node, stores nodes for each moecule
+    this.moleculeNodeMap = {}; // molecule ID => node, stores nodes for each molecule
     this.blinkTimeout = null; // NOT zero, since that could be a valid timeout ID for window.setTimeout!
     this.boxNode = new Node();
     this.moleculeIdThumbnailMap = {}; // maps moleculeId => Node (thumbnail view for the molecule)
@@ -213,7 +212,7 @@ class CollectionBoxNode extends VBox {
     let x = 0;
     moleculeNodes.forEach( moleculeNode => {
       moleculeNode.setTranslation( x, ( maxHeight - moleculeNode.height ) / 2 );
-      x += moleculeNode.width + MOLECULE_PADDING;
+      x += moleculeNode.width;
     } );
   }
 

diff --git a/js/common/view/CollectionPanel.js b/js/common/view/CollectionPanel.js
@@ -53,7 +53,7 @@ class CollectionPanel extends Panel {
       font: new PhetFont( {
         size: 22
       } ),
-      maxWidth: BAMConstants.TEXT_MAX_WIDTH
+      maxWidth: BAMConstants.TEXT_MAX_WIDTH - 10
     } );
     this.layoutNode.addChild( yourMoleculesText );
 
@@ -63,7 +63,7 @@ class CollectionPanel extends Panel {
         size: 16,
         weight: 'bold'
       } ),
-      maxWidth: BAMConstants.TEXT_MAX_WIDTH
+      maxWidth: BAMConstants.TEXT_MAX_WIDTH - 10
     } );
 
     // Manages changing the label of the current collection