Maintenance release to convert R to TM logos.

[samreid]

In #33 @amanda-phet converted the logos to use TM. Kathy said:

We will do a maintenance release. To be scheduled - we were waiting until past the January deadline, but now that is the time. It should be brought up in dev meeting tomorrow.

Some questions:

1. Timeline, priority and assignee (see also Maintenance release round robin of developers perennial#110 )
2. Will this be for PhET-iO simulations as well, or can they be skipped?

[amanda-phet]

2. Will this be for PhET-iO simulations as well, or can they be skipped?

My guess is they can be skipped since that logo already uses TM.

[pixelzoom]

Wondering why (c) would have been in the logos. @samreid Do you mean convert from (R) to TM ?

[samreid]

Corrected, thanks!

[samreid]

Please note #33 (comment)

Before going through maintenance releases, @kathy-phet and @amanda-phet should review the changes.

Also, @ariel-phet pointed out that he saw an issue with the shish-ka-bob menu that he may want to address in this same maintenance release.

[amanda-phet]

The changes look good to me.

[samreid]

Note there are commits across the brand repo and joist repo that you will need. Please see #33 for full details (note it's a long issue so some commits and comments are collapsed in the GitHub thread).

UPDATE: And also a commit from #35

[pixelzoom]

Over in phetsims/perennial#110:

@Denz1994 volunteered to pair with @jonathanolson for the phetsims/brand#34 batch of maintenance releases.

[kathy-phet]

Before doing maintenance, address issue phetsims/brand#35

[ariel-phet]

Looks like @samreid has committed a fix for #35

I think we are all good to go here. I am just going to verify everything on master.

[ariel-phet]

All looks good over to you @Denz1994!

[samreid]

@jonathanolson and @Denz1994 and I reviewed the changes that will be necessary for this:

We identified:

• brand/phet/logo-on-white.png
• brand/phet/logo.png
• brand/phet/splash.svg
• brand/phet/js/Brand.js
• both files in phetsims/joist@6f2d60b

We also noticed some changes in the SVG metadata and we aren't 100% sure that has been fully cross-platform tested.

The prior version has:

id="Layer_2" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
width="276px" height="132px" viewBox="114.001 114 276 132" enable-background="new 114.001 114 276 132"

The new version has:

id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
width="276px" height="132px" viewBox="0 0 276 132" enable-background="new 0 0 276 132"

We agreed this warrants cross platform testing before maintenance release. I built a local version of wave-interference and checked the splash screen on Mac/Chrome, Mac/Firefox and iPad Air 2 iOS 11.4.1 and did not see any problems.

UPDATE: I also launched it on an iPhone and did not see any problems.

[Denz1994]

During maintenance release step 8 for branch molecule-shape 1.1. The splash image has different dimensions causing the splash image to be off-centered during sim startup. It looks like we will need to patch more than what was expected from #34 (comment).

@jonathanolson and I require some assistance from @samreid to continue. We will collab with @samreid at his next availability.

[samreid]

My apologies for the trouble. Can you describe how to reproduce the problem? I checked out molecule-shapes 1.1 and ran grunt checkout-shas, and the logos still show (R) instead of TM.

UPDATE: master shows width="276px" height="132px", whereas the molecule shapes one has width="504px" height="360px", so we will likely need to (a) republish it from newer shas or (b) create changes that are compatible with the older shas. Maybe it will be helpful to iterate through sims and see how many are affected.

UPDATE: It looks like Nov 30, 2016 was when the splash screen changed size when we added the loading progress bar: 35a47f2

[samreid]

As I was looking at this, I noted the polygon fill have trailing tabs:

		<polygon fill="#FFFFFF" points="16.942,125.172 11.261,116.781 7.651,116.781 7.651,130.766 11.261,130.766 11.261,122.441 
			16.987,130.766 20.553,130.766 20.553,116.781 16.942,116.781 		"/>

But it appears it has been that way for a long time.

[jonathanolson]

Maintenance release for this completed, closing.