-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce "Graph Values" readout to 4 sig figs on the vertical axis #114
Comments
@chrisklus this change I would think should be quite straightforward, worth doing before the spectrum change #115 |
Ready for review. I only saw one usage of number's Also, I noticed that at 200 and 250 K, the x-axis outputs 5 sig figs, as well as 3 sig figs for values less than 1 (if I'm not mistaken). Should these be modified as well? |
I like that now the sim looks more symmetric with the four sig figs, except for small numbers. I understand that it still being 4 sig fig, but I feel it very tie (top picture is published sim version, bottom picture is @chrisklus version): I don't know if it's possible to have 4 sig fig, but once that is zero, dot some number, only have 3 decimals. What do you think @ariel-phet ? |
@DianaTavares @chrisklus frankly the sig figs on this sim are all over the map, there is really no consistency, and I don't think it is worth the effort to try to get it consistent (x axis varies, y axis varies, intensity, sig figs in temperature...) @chrisklus currently the sim looks like on the y-axis (on master) it is doing something like Numbers above 100: ###.# On the x-axis basically just giving numbers to 3 decimal places (no sig fig consistency) Let's make one tweak for the y-axis |
Mike D suggested reducing the Graph Values" readout to 4 sig figs on the vertical axis (horizontal is good). I think it is a good suggestion.
The text was updated successfully, but these errors were encountered: