-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make things pretty #26
Comments
Let me know what you would like to do. |
Thanks @zepumph. From dev meeting yesterday, @ariel-phet recommended I take a first pass and then work with a designer to make improvements. Perhaps you could give me a tour, and if I feel comfortable enough, I can go ahead and dive in. |
Sure thing. Let me know when you want a tour! |
@zepumph gave me a very nice tour, so i'm feeling up to speed on how the front end is set up. Since it's using Handlebars and Bootstrap, I proposed porting this to React (the new website is in React) For starters, I'm going to get a React environment working and then port and style the "Components by Sim" and "Sim by Components" pages that @zepumph recently created. |
React has been difficult to get working with CDNs, and @mattpen thinks it will be messy to continue down this path. I was hoping this would work because anyone could load a live version of binder locally just like a sim, without any additional steps. Instead, we could run it locally with npm. From slack: Matt Pennington 10:39 AM He also mentioned that we could create a grunt task for this, so devs would just need to run |
After developer meeting discussion, we discussed using a compile step instead of having that done inline in the browser via script type=text/babel. That seems pretty standard and would allow us to build the site. If in the future we figure how to get rid of the build step, the code maybe wouldn't need to change too much. We can also use filesystem watchers, to automatically compile on code changes. |
Today is dev meeting (relating to phetsims/tasks#980), it was mentioned that perhaps it would be good to get @chrisklus, the front-end whiz, in on this repo to help out making UI improvements. I'm not exactly sure what this will look like, but I'm making an issue to begin the discussion.
@chrisklus perhaps you just want to go for it, or start working with a designer. Or maybe we can talk and I can give you a tour of the limited things I know about the front end. For example it is using a few templating technologies, like
handlebars
and perhaps mustache too. There is also some fancy stuff in there about compiling the common code markdown files into the generated binder output.The text was updated successfully, but these errors were encountered: