Move forward/backward should change the visible ordering in the combobox

[Nancy-Salpepi]

Test device
MacBook Air (m1 chip)

Operating System
13.1

Browser
safari 16.2

Problem description
For phetsims/qa#894, if I removed the two solutes (Co(NO3)2 and CoCl2) listed in the combobox after "Drink Mix," and then try to move "Drink Mix" down in the order, I have to press the down arrow three times before I see a change in the combobox order.

@arouinfar said that this issue was addressed in pH scale but is part of common code. phetsims/ph-scale#266

Visuals

comboboxordering.mp4

[pixelzoom]

I'm guessing that this is a bug in ComboBoxListbox keydown handler. Disappointing that this doesn't work, given that this was a primary reason for reworking ComboBox. I'm going to defer to @samreid for fixing this.

[samreid]

I imagine this will be fixed by cherry picking phetsims/scenery@6fe6985

[pixelzoom]

@samreid That cherry-pick you're referring to (phetsims/scenery@6fe6985) was committed on 1/11/2023. Why is it not in 1.7.0-rc.2 that was created on 2/6/2023? This suggests that there's still a problem with the 1.7 release branch. No cherry-pick should be necessary.

[samreid]

I ran

cd beers-law-lab
git checkout 1.7
grunt checkout-shas

Then I checked the history for scenery, and saw this:

Note there are no commits from Jan 11, but plenty of commits afterwards.

Checking the history from master, I see the Jan 11 commit and the other nearby commits from @jessegreenberg:

So the branch is somehow missing this commit. How is this possible? What else is it missing?

[samreid]

Oh wait, the dot for the Jan 11 commit is in the branch--you can see the dot is on the left. And it was not merged until Feb 3. So likely we just don't understand why phetsims/scenery@6fe6985 says master.

@pixelzoom OK to relabel ready-for-cherry-pick?

[pixelzoom]

I don't understand. This issue was reported yesterday 2/7, and is therefore for 1.7.0-rc.2 -- after the shas in the 1.7 branch were fixed in #327. The sha that you're proposing to cherry-pick is dated 1/11/23. How can that commit not be in the 1.7 release, and why do we think it's appropriate to cherry-pick it?

[pixelzoom]

Discussed with @samreid on Zoom. Commit phetsims/scenery@6fe6985 was done in a branch 'carousel-dynamic', and it was not merged to master until after the 1.7 release branch was created. So yes, it needs to be cherry-picked. Labeling as such.

[samreid]

@pixelzoom would you like me to cherry pick this commit? And should I do that right away?

[pixelzoom]

I have a couple of other things to cherry-pick today, so I'll handle it.

[pixelzoom]

Cherry-picks completed for beers-law-lab 1.7 anf concentration 1.7 in the above commits.

To verify in the next RC, for both beers-law-lab and concentration:

• Follow the steps in Move forward/backward should change the visible ordering in the combobox #325 (comment)

[stemilymill]

looks good in beers law lab and concentration