-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Particles.changedCallbacks to use Emitter #216
Comments
This sim implements its own listener mechanism because (1) it was ported directly from the Java version, and (2) the port predates the existence of Emitter. I question the value (and cost) of such as small amount of working/straightforward code. But I guess it's good to be consistent. |
Same pattern noted in gravity-and-orbits and scenery, see above issues. |
Conversion to Emitter completed. Also required a change to TShakerParticles. Test in requirejs mode and with instance-proxies wrapper. Next savings was 11 lines of code. @samreid please review. |
The change set looks correct and I tested by saturating a solution then diluting it. Closing. |
Noted during #213.
Particles.js defines:
Then Precipitate.js has this code:
And ShakerParticles.js defines this code:
This code should be rewritten to use axon Emitter.
The text was updated successfully, but these errors were encountered: