ChartCanvasNode demo looks messed up

[pixelzoom]

@samreid is the bamboo demo for ChartCanvasNode supposed to look like this?

[samreid]

Yes, it's a demo for missing data. But we could move that to a separate labeled test so it's not confusing if that would help.

[pixelzoom]

OK, gotcha. At the very least, that should be documented in DemoChartCanvasNode.js.

And I think that perhaps we should carve out some time to clean up the bamboo demos. Some of these demos are confusing because they aren't really demos of one or two specific things, they are testing a bunch of things. For example, testing SpanNode in DemoLinePlot. New issue?...

[samreid]

The current documentation is a line comment here:

for ( let x = min; x <= max; x += delta ) {

  // Test holes in the data
  const data = ( Math.abs( x ) < 0.1 && x < 0 ) ? null : new Vector2( x, Math.sin( x * frequency + offset ) );
  dataSet.push( data );
}

I added another note and revised the demo so that only one curve is missing data.

It seems the missing data doesn't need to be a separate test because missing data is a feature of ChartCanvasNode.

For example, testing SpanNode in DemoLinePlot.

To me, it makes sense to show the SpanNode in the context of a fuller plot, how do you recommend to organize this? Please open a new issue for that depending on your recommendation.

[pixelzoom]

Doc looks good, and I think it's a nice change to only have a hole in 1 plot -- it looks less like a bug.

To me, it makes sense to show the SpanNode in the context of a fuller plot, how do you recommend to organize this? Please open a new issue for that depending on your recommendation.

I'm not suggesting that things should not be showing in context. What I'm pointing out is that there is generally too much going on in some of these demos, and some components (like SpanNode) cannot be selected via the combo box. I'll create a new GitHub issue for "clean up demos" (see #28).