-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO: what if the chart area changes #15
Comments
If the view dimensions of the ChartModel were to change, by using const clippedNode = new Node( {
clipArea: chartRectangle.getShape(),
...
} );
chartRectangle.localBoundsProperty.lazyLink( localBounds => {
clippedNode.clipArea = chartRectangle.getShape();
} ); That's pretty standard/straightforward, so I think we can simply delete these TODOs. @samreid your thoughts? |
The main question for me is if we should provide a bamboo type like |
I can't recall implementing a sim chart whose view bounds change, so I doubt that |
It seems most appropriate to develop this in context, if and when we need it. Unassigning for now. |
In DemoCanvasLinePlot.js and DemoLinePlot.js:
The text was updated successfully, but these errors were encountered: